Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(#2128): deprecate legacy adapters #2143

Merged
merged 2 commits into from
Nov 6, 2023
Merged

refactor(#2128): deprecate legacy adapters #2143

merged 2 commits into from
Nov 6, 2023

Conversation

bossenti
Copy link
Contributor

@bossenti bossenti commented Nov 6, 2023

Purpose

Marked adapters as deprecated as described in #2128.
Some adapters were removed immediately since they only contained dead code (see list below).

Remarks

PR introduces (a) breaking change(s): yes

PR introduces (a) deprecation(s): yes

Breaking Changes

The following legacy adapters are removed immediately:

  • GdeltAdapter
  • Iex*Adapter
  • OpenSenseMapAdapter

Deprecations

The following adapters are deprecated and will be removed in the next release (version 0.95.0):

  • CoindeskAdapter
  • FlicMQTTAdapter
  • SlackAdapter
  • TiSensorAdapter
  • WikipediaAdapter

@github-actions github-actions bot added java Pull requests that update Java code connect Related to the `connect` module (adapters) backend Everything that is related to the StreamPipes backend documentation Everything related to documentation labels Nov 6, 2023
@bossenti bossenti added deprecation Assigned to pull requests or issues that introduce a deprecation. breaking change Indicates that a PR or issue yields to a breaking change and removed java Pull requests that update Java code backend Everything that is related to the StreamPipes backend documentation Everything related to documentation labels Nov 6, 2023
@bossenti bossenti added this to the 0.95.0 milestone Nov 6, 2023
@bossenti bossenti mentioned this pull request Nov 6, 2023
Closed
2 tasks
@github-actions github-actions bot added java Pull requests that update Java code backend Everything that is related to the StreamPipes backend documentation Everything related to documentation testing Relates to any kind of test (unit test, integration, or E2E test). labels Nov 6, 2023
@bossenti bossenti modified the milestones: 0.95.0, 0.93.0 Nov 6, 2023
@bossenti bossenti merged commit 0b26f5a into dev Nov 6, 2023
18 checks passed
@bossenti bossenti deleted the 2128-deprecated-adapters branch November 6, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenthe tenthe tenthe approved these changes

Assignees
No one assigned
Labels
backend Everything that is related to the StreamPipes backend breaking change Indicates that a PR or issue yields to a breaking change connect Related to the `connect` module (adapters) deprecation Assigned to pull requests or issues that introduce a deprecation. documentation Everything related to documentation java Pull requests that update Java code testing Relates to any kind of test (unit test, integration, or E2E test).
Projects
None yet
Milestone
0.93.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bossenti @tenthe