Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add error handling to OI4 and MQTT adapters #2848

Merged
merged 4 commits into from
May 10, 2024
Merged

fix: Add error handling to OI4 and MQTT adapters #2848

merged 4 commits into from
May 10, 2024

Conversation

dominikriemer
Copy link
Member

Purpose

Add some improvements to the MQTT and OI4 adapters:

  • Error messages don't get lost and are sent to the UI
  • Avoid infinite loops in case schema retrieval fails
  • Support two different formats as OI4 payload

Remarks

PR introduces (a) breaking change(s): <yes/no>

PR introduces (a) deprecation(s): <yes/no>

@github-actions github-actions bot added java Pull requests that update Java code connect Related to the `connect` module (adapters) backend Everything that is related to the StreamPipes backend testing Relates to any kind of test (unit test, integration, or E2E test). labels May 10, 2024
@tenthe tenthe merged commit 8eb483c into dev May 10, 2024
21 checks passed
@tenthe tenthe deleted the fix-mqtt-oi4 branch May 10, 2024 08:36
dominikriemer added a commit that referenced this pull request May 10, 2024
@dominikriemer @bossenti
fix: Add error handling to OI4 and MQTT adapters (#2848)
a2f8f3a 
* fix: Add error handling to OI4 and MQTT adapters

* Fix checkstyle

* Fix checkstyle

* style: improve JSON strings

---------

Co-authored-by: bossenti <bossenti@posteo.de>
@bossenti bossenti added this to the 0.95.0 milestone May 10, 2024
@bossenti bossenti added the bug Something isn't working label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenthe tenthe tenthe approved these changes

Assignees
No one assigned
Labels
backend Everything that is related to the StreamPipes backend bug Something isn't working connect Related to the `connect` module (adapters) java Pull requests that update Java code testing Relates to any kind of test (unit test, integration, or E2E test).
Projects
None yet
Milestone
0.95.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dominikriemer @tenthe @bossenti