Pimp my struts #183
Merged
Pimp my struts #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling c14dca5 on lukaszlenart:pimp-my-struts into ** on apache:master**. |
|
@apache/struts-committers I think this is ready to be merged |
|
I like it 👍 |
|
It's great 👍 just coverall comment here is somehow different than here. |
|
because there is nothing to compare to |
|
Oh sorry, I failed to catch that :( you're right. Thanks for your works 👍 |
|
I compared this PR changes with Apache Commons Lang and it seems ok to go :) |
|
@apache/struts-committers I have added two more plugins to discover outdated dependencies |
|
Changes Unknown when pulling ad98881 on lukaszlenart:pimp-my-struts into ** on apache:master**. |
|
Changes Unknown when pulling 76d0bc5 on lukaszlenart:pimp-my-struts into ** on apache:master**. |
|
No complains so LGTM :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small tweaks to be better visible via GitHub
Coverage report is available here
https://coveralls.io/github/apache/struts