Proposed WW-5067 change #401
Conversation
------
Proposed list of library version updates:
---
- cdi-api 1.0-SP4 -> 1.2
- weld-core 1.0.1-SP4 -> 2.2.16.SP1
- weld-se 1.0.1-Final -> weld-se-core 2.2.16.SP1
- slf4j-api 1.7.28 -> 1.7.30
- slf4j-simple 1.7.28 -> 1.7.30
- jackson 2.10.0 -> 2.10.3
- ognl 3.1.26 -> 3.1.28
- asm 7.1 -> 7.3.1
- spring 4.3.25.RELEASE -> 4.3.26.RELEASE
- freemarker 2.3.28 -> 2.3.30
- org.apache.felix.main 4.6.1 -> 6.0.3
---
Proposed list of Maven plugin version updates:
---
- doxia-core 1.8 -> 1.9.1
- doxia-module-markdown 1.7 -> 1.9.1
- maven-project-info-reports-plugin 2.7 -> 3.0.0
- updateimpact-maven-plugin 1.0.10 -> 1.0.12
- maven-surefire-plugin 2.22.1 -> 3.0.0-M4
- maven-war-plugin 2.1 -> 3.2.3
- maven-dependency-plugin 2.10 -> 3.1.2
- dependency-check-maven 3.3.4 -> 5.3.2
Note: Unable to upgrade maven-bundle-plugin past 2.1.0 as it introduced
OOM during JDK7 builds with default heap settings.
---
|
Coverage remained the same at 47.069% when pulling 77cfae3 on JCgH4164838Gh792C124B5:WW-5067-25x into 47c87bc on apache:struts-2-5-x. |
|
Hello Apache Struts Team. This PR is pretty straightforward, but any of the changes can be modified if needed after review and discussion. Local builds with JDK7 and JDK8 completed successfully, but with JDK11 locally I experienced test failures in DateRangeValidatorTest and VisitorFieldValidatorTest of struts-core (could be a local build issue with my environment but I wanted to note it in case it turns out to be significant in the future). The Travis CI builds for JDK7/8/9/11 against the PR all completed successfully, though (I'll see if I can figure out what might be happening locally that is different). Let me know if any additional changes could be considered (there are a few libraries with newer versions that are not JDK7 compatible, so they cannot be updated in 2.5.x). |
|
I'm ok with this change, even if it will fail once merged into master branch we can always fix it there :) LGTM 👍 |
Proposed WW-5067 change
Proposed list of library version updates:
Proposed list of Maven plugin version updates:
Note: Unable to upgrade maven-bundle-plugin past 2.1.0 as it introduced
OOM during JDK7 builds with default heap settings.