[WW-5077] DMI aware pattern #425
Conversation
|
Coverage increased (+0.005%) to 47.102% when pulling 9b3a23e on WW-5077-dmi-aware into 89e02a4 on struts-2-5-x. |
| @@ -35,7 +37,11 @@ | |||
| private static final Logger LOG = LogManager.getLogger(DefaultAcceptedPatternsChecker.class); | |||
|
|
|||
| public static final String[] ACCEPTED_PATTERNS = { | |||
| "\\w+((\\.\\w+)|(\\[\\d+\\])|(\\(\\d+\\))|(\\['(\\w|[\\u4e00-\\u9fa5])+'\\])|(\\('(\\w|[\\u4e00-\\u9fa5])+'\\)))*" | |||
| "\\w+((\\.\\w+)|(\\[\\d+])|(\\(\\d+\\))|(\\['(\\w|[\\u4e00-\\u9fa5])+'])|(\\('(\\w|[\\u4e00-\\u9fa5])+'\\)))*" | |||
There was a problem hiding this comment.
Looks strange for me. Closing escaped [ brackets with not-escaped ] brackets?
There was a problem hiding this comment.
It was suggested by IDEA, restored the previous version :)
There was a problem hiding this comment.
Ah sorry it was right.
And I spotted it's nice I think to refactor ((\\.\\w+)|(\\[\\d+\\])|(\\(\\d+\\))|(\\['(\\w|[\\u4e00-\\u9fa5])+'\\])|(\\('(\\w|[\\u4e00-\\u9fa5])+'\\)))* part e.g. named EXTENSION_PATTERN or so because it's same in both.
There was a problem hiding this comment.
Yes, but I would like to keep them as is, it's easier to understand what's going on. Also future changes to the patterns want affect each other.
Refs WW-5077