This repository has been archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-759. Update submarine-operator.md #530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The document of submarine-operator is outdated, and thus we cannot launch the submarine operator with this document.
For example,
(1) (submarine-operator.md) Kind v0.6.0 deprecates
kind get kubeconfig-path(2) (manifests/submarine-operator/deployment.yaml)
selectorfield is necessary.(3) (manifests/submarine-operator/deployment.yaml) Now, deployment is
apiVersion: apps/v1rather thanextensions/v1beta1.(4) The .yaml files in
manifests/are very different with the files inhelm-charts/. Therefore, some errors will occur. For instance, there is noconfigMapinhelm-charts/submarine/templates/submarine-server.yaml, but aconfigMapis defined inmanifests/submarine-cluster/submarine-server.yaml.Hence, we need to update this document, and we should refactor this component next.
What type of PR is it?
[Documentation]
Todos
What is the Jira issue?
https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-759?filter=allopenissues
How should this be tested?
Screenshots (if appropriate)
Questions: