Skip to content
This repository has been archived by the owner on Jul 10, 2024. It is now read-only.

SUBMARINE-1009. Support mypy for Submarine SDK #739

Closed
wants to merge 4 commits into from

Conversation

KUAN-HSUN-LI
Copy link
Member

What is this PR for?

mypy is an optional static type checker for Python.
With mypy we can find bugs in our programs without even running them.

What type of PR is it?

[Improvement]

Todos

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-1009

How should this be tested?

ci pass

Screenshots (if appropriate)

Questions:

  • Do the license files need updating? No
  • Are there breaking changes for older versions? No
  • Does this need new documentation? Yes

Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @KUAN-HSUN-LI

@asfgit asfgit closed this in 5cd74b9 Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants