This repository has been archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-1045. Add static type parameter in submarine-sdk #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Re-post the PR due to previous PR include other commits |
|
@rayray2002 sorry, could you fix the merge conflict? I will merge it then. |
rayray2002
force-pushed
the
SUBMARINE-1045
branch
from
64336de
to
75f4022
Compare
Okay I’ll fix it. |
rayray2002
force-pushed
the
SUBMARINE-1045
branch
2 times, most recently
from
7148774
to
8a00053
Compare
rayray2002
force-pushed
the
SUBMARINE-1045
branch
from
8a00053
to
53256dd
Compare
fixed |
pingsutw
approved these changes
Oct 29, 2021
Comment on lines
+40
to
+39
| tracking_uri: str = None, | ||
| registry_uri: str = None, | ||
| aws_access_key_id: str = None, | ||
| aws_secret_access_key: str = None, |
There was a problem hiding this comment.
we should use typing.Optional[str] when default value is None
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Add static type parameter in submarine-sdk
What type of PR is it?
[Improvement]
Todos
What is the Jira issue?
https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-1045
How should this be tested?
mypy passed
runtime type check
Screenshots (if appropriate)
Questions: