Skip to content
This repository has been archived by the owner on Jul 10, 2024. It is now read-only.

SUBMARINE-1140. Some fixes for auto generating python from swagger #836

Closed
wants to merge 4 commits into from

Conversation

atosystem
Copy link
Contributor

@atosystem atosystem commented Dec 16, 2021

What is this PR for?

  1. Fix ./dev-support/pysubmarine/gen-sdk.sh for cross platform issue
  2. Fix ./dev-support/pysubmarine/gen-sdk.sh for wrong auto-format path
  3. Fix Bootstrap.java for generating API specs for notebook, experiment and environment together.
  4. Update readme(./website/docs/userDocs/submarine-sdk/pysubmarine/developmend.md) for a more detailed description for using swagger.

What type of PR is it?

[Improvement]

Todos

  • Edit java code

What is the Jira issue?

https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-1140

How should this be tested?

Screenshots (if appropriate)

Questions:

  • Do the license files need updating? No
  • Are there breaking changes for older versions? No
  • Does this need new documentation? Yes

Copy link
Member

@KUAN-HSUN-LI KUAN-HSUN-LI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@KUAN-HSUN-LI KUAN-HSUN-LI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to this feature. Can you also provide a test to check if there is a mismatch between the Python API and Java API? (Just like what they do in the operator)

@asfgit asfgit closed this in 937a16f Dec 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants