Replies: 5 comments 6 replies
-
This all seems great. The one thing I'd like to ask for in this proposal is that if we make these changes, please update/append the existing documentation. Otherwise, these all seem like welcome improvements! |
Beta Was this translation helpful? Give feedback.
-
Awsome changes!
Also a bunch of thoughts on permalinks and overall usecases. |
Beta Was this translation helpful? Give feedback.
-
This all look great changes. This feature allows users to customize the email subject of a report or alert. In the report submission creation interface, add a text area for entering the email subject. If a user inputs a value in this field, the email's subject will be this value. If not, the system will assign a default email subject line. This is what it look like when apply to the current create report/alert modal: This change need migrationTo incorporate this feature, we will need to initiate a database migration to add columns dedicated to storing email subject lines. More information: customize email subject name |
Beta Was this translation helpful? Give feedback.
-
Hi @yousoph, thank you for proposing the above changes and improvements to the alert/report - they are really exciting and address a number of user feature requests. We have some feedback points we would like to share and are happy to discuss further to make these feature improvements bullet proof for the long term. On the UI improvements (points 1&2):
On “3. New Feature - Filter Configuration”: Few questions we had:
There was a past proposal to use permalinks, which didn’t go through with the reasoning that it’s not too intuitive for users (users don’t have visibility of the dashboard state used to generate the permalink, and to make changes they need to create a new permalink). One potential solution we wanted to propose, which handles some of the above complexity, and gets around the permalink user experience challenges – What if we introduce a feature in the dashboard to set a report based on the Dashboard’s current state? Users would have a button in the dashboard that would internally generate the permalink. In the email alerting feature, users would be able to see a preview (screenshot) of the dashboard, and if they want to make changes to the email report, there's a button to take them back to the dashboard where they can edit and save the dashboard state (internally this means updating the permalink). Given that we're using the dashboard to generate the reports, we're able to handle really specific use cases such as filters with dependencies, global and nested tab selection, cross-filtering, etc. On “4. New Feature - Tab Configuration”: Similarly as with filters, tab configuration is a very common feature request, but it can get quite complex. We feel this needs some additional thinking to ensure it works - especially for nested tabs.
On “New feature - Send test alert/report”: How will this feature work for alert? What is the expectation users may want to see for alert? (if the threshold is not met - the alert wouldn’t fire → do users want to see how the report would look if the condition was met, OR do they want to be able to validate their SQL)? Both? Will the test email show in the activity log? Thanks! |
Beta Was this translation helpful? Give feedback.
-
Hi, I am curious about this feature. Can you please let me know if there already is some PR to incorporate this change or is this still under development? |
Beta Was this translation helpful? Give feedback.
-
Context
There have been a few feature requests around alerts and reports around providing more filter and/or tab details when setting up a report or alert.
See the below for details on the feature requests:
Filters and tabs: #18472
Tabs: #18475
Permalink to provide additional filter and tab info: https://github.com/apache/superset/discussions/24843 and #22905
Send test report feature: #18472 (comment)
We wanted to propose some UI updates to the alert and report creation flow that will include the option to set up filters and tabs, as well as update the grouping of the fields to improve the clarity of the modal and streamline the configuration of the reports/alerts.
Current Design
Alerts:
Reports:
Goals
Proposed Changes
1. Fields grouped into sections
The fields in the modal will be grouped into logical categories, similar to the pattern used in database connection modal. This categorization will improve the user's ability to quickly locate and interact with the relevant options.
2. Step-by-Step Setup Process
Instead of displaying all options at once, the modal will show a step by step setup process, with each step clearly indicating the information required. Users can still jump around between sections if desired, but the modal focuses on one section at a time.
3. New Feature - Filter Configuration
When a dashboard is selected, users will be able to configure filters and filter values for the report using the filters that are already defined on the dashboard. Multiple filters can be selected.
4. New Feature - Tab Configuration
When a dashboard with multiple tabs is selected, the user will be able to specify the tab that should be used for the report.
5. New feature - Send test alert/report
Users are able to send a test alert/report to themselves, all recipients, or owners of the report to verify their settings.
Future Considerations
We felt the dropdown methods to set up filters and tabs would be more intuitive for users than permalinks would be. However, permalinks could still be a future addition to this modal to solve for anchored charts, other URL params, etc.
Beta Was this translation helpful? Give feedback.
All reactions