Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong slice id used somewhere #1113

Closed
xrmx opened this issue Sep 15, 2016 · 2 comments
Closed

wrong slice id used somewhere #1113

xrmx opened this issue Sep 15, 2016 · 2 comments
Labels
!deprecated-label:bug Deprecated label - Use #bug instead

Comments

@xrmx
Copy link
Contributor

xrmx commented Sep 15, 2016

In e895807 when you open the visualization type menu in the explorer view this get called /caravel/explore/table/2/7b9776076d5fceef4993b55c9383dedd.gif, redirected to
/caravel/explore/table/2/7b9776076d5fceef4993b55c9383dedd.gif/ and finally explode with this:

  File "/home/rm/caraveltest/venv/lib/python3.4/site-packages/flask/app.py", line 1988, in wsgi_app
    response = self.full_dispatch_request()
  File "/home/rm/caraveltest/venv/lib/python3.4/site-packages/flask/app.py", line 1641, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/home/rm/caraveltest/venv/lib/python3.4/site-packages/flask/app.py", line 1544, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/home/rm/caraveltest/venv/lib/python3.4/site-packages/flask/_compat.py", line 33, in reraise
    raise value
  File "/home/rm/caraveltest/venv/lib/python3.4/site-packages/flask/app.py", line 1639, in full_dispatch_request
    rv = self.dispatch_request()
  File "/home/rm/caraveltest/venv/lib/python3.4/site-packages/flask/app.py", line 1625, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/home/rm/caraveltest/venv/lib/python3.4/site-packages/flask_appbuilder/security/decorators.py", line 26, in wraps
    return f(self, *args, **kwargs)
  File "/home/rm/caraveltest/venv/lib/python3.4/site-packages/caravel-0.10.0-py3.4.egg/caravel/models.py", line 1711, in wrapper
    slice_id = int(slice_id) if slice_id else 0
ValueError: invalid literal for int() with base 10: '7b9776076d5fceef4993b55c9383dedd.gif'
@xrmx xrmx added the !deprecated-label:bug Deprecated label - Use #bug instead label Sep 15, 2016
@xrmx xrmx changed the title wrong slice_id used somewhere wrong slice id used somewhere Sep 15, 2016
@xrmx
Copy link
Contributor Author

xrmx commented Sep 18, 2016

On f17cfcb the very same request is done too but it just return a 404 without even redirecting.

@bkyryliuk
Copy link
Member

Looks like it's resolved on master, closing the issue.

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 17, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 24, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 25, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
!deprecated-label:bug Deprecated label - Use #bug instead
Projects
None yet
Development

No branches or pull requests

2 participants