[explore] Time Series Columns Configuration - no save button, (i) wrapped to new line

[zuzana-vej]

Screenshot

Issue 1: No Save Button, however the configuration gets saved is user clicks outside the configuration popup. Is this expected behavior? Given all other settings have save button, it would be good for consistency to have the Save here too.

Issue 2:
Here the (i) wraps to a new line, consider keeping it inline (make the popup window slightly larger?)

Description

Described above alongside screenshot.

Design input

Confirm if the SAVE button should be on the "Time Series Columns" configuration popup.

[junlincc]

No Save Button, however the configuration gets saved is user clicks outside the configuration popup. Is this expected behavior?

It's not 😅, we came across this issue when we audit all charts but decided to let it go back then. agreed we should get it fixed.

Here the (i) wraps to a new line, consider keeping it inline (make the popup window slightly larger?)

this is happening in many chart controls. we will see if we can get it fixed(in our Explore cosmetic bash) next week for patch release

Thank you for reporting 🙏 @zuzana-vej

[zuzana-vej]

Low pri bug, but wanted to ping a reminder so that it's not completely lost. cc @junlincc

[zuzana-vej]

@junlincc curious if this might be prioritized not in near future?

[junlincc]

we will have a bash for all the good first issue in mid May

cc @amitmiran137 thanks for organizing 🙏

[michael-s-molina]

@junlincc I'm on it!

[zuzana-vej]

Thank you @michael-s-molina!