Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Color scheme won't be discarded when discarding changes #17243

Closed
geido opened this issue Oct 27, 2021 · 1 comment · Fixed by #17392
Closed

[Dashboard] Color scheme won't be discarded when discarding changes #17243

geido opened this issue Oct 27, 2021 · 1 comment · Fixed by #17392
Assignees
Labels
#bug Bug report

Comments

@geido
Copy link
Member

geido commented Oct 27, 2021

A clear and concise description of what the bug is.

How to reproduce the bug

  1. Go to a Dashboard
  2. Click on Edit dashboard properties
  3. Change the color scheme and click Save
  4. Without saving the whole dashboard, click on "Discard changes"
  5. The page will refresh and the color scheme change hasn't been discarded

Expected results

Saving changes in the "Edit dashboard properties" Modal should only be effective when the whole Dashboard is saved. When discarding the changes, any change should reset.

Actual results

The color scheme is not discarded

Screenshots

untitled.dashb.2.mp4

Environment

  • browser type and version: Chrome
  • superset version: master
@geido geido added the #bug Bug report label Oct 27, 2021
@geido
Copy link
Member Author

geido commented Oct 27, 2021

@junlincc @jinghua-qa FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant