[bug] fix explore action buttons bug #1269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascott
changed the title
|
oh we shouldn't have to reload the whole page, let me try something else |
|
thx for taking a look @mistercrunch! |
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
…#1269) * fix(plugin-chart-pivot-table): dont apply colors to subtotals * Rename customize metrics to conditional formatting
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
…#1269) * fix(plugin-chart-pivot-table): dont apply colors to subtotals * Rename customize metrics to conditional formatting
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
…#1269) * fix(plugin-chart-pivot-table): dont apply colors to subtotals * Rename customize metrics to conditional formatting
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
…#1269) * fix(plugin-chart-pivot-table): dont apply colors to subtotals * Rename customize metrics to conditional formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a quick hack to fix the issue with the explore button action buttons not getting the updated slice properties once query is clicked. now when query is clicked, we will also reload the page so the components get the updated slice.
i tried to just re-render the components after query click, but the slice object doesn't get updated on query, only the url params get updated.
i spent some time trying to do this in a better way, but since we are rebuilding the explore view, decided to spend less time on a real solution and opted for this hack instead.
@mistercrunch if you know of a better way to handle this in the interim, plz let me know!
@vera-liu @bkyryliuk