test: Fixes PropertiesModal_spec #13548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Codecov Report
@@ Coverage Diff @@
## master #13548 +/- ##
==========================================
- Coverage 77.31% 73.56% -3.75%
==========================================
Files 903 603 -300
Lines 45926 21406 -24520
Branches 5624 5641 +17
==========================================
- Hits 35508 15748 -19760
+ Misses 10282 5524 -4758
+ Partials 136 134 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
pkdotson
approved these changes
Mar 15, 2021
yardz
approved these changes
Apr 1, 2021
amitmiran137
pushed a commit
that referenced
this pull request
Apr 2, 2021
* master: (26 commits) chore: bump to new superset-ui version (#13932) fix: do not run containers as root by default in Helm chart (#13917) feat(explore): adhoc column formatting for Table chart (#13758) fix(sqla-query): order by aggregations in Presto and Hive (#13739) feat(alert/report): add ALERTS_ATTACH_REPORTS feature flags + feature (#13894) test: Fixes PropertiesModal_spec (#13548) fix: Pin Prophet dependency after breaking changes (#13852) test: Adds tests to dnd controls (#13650) test: Adds tests to the AnnotationLayer component (#13748) test: Refactor and enhance tests for the Explore DatasourcePanel Component (#13799) Add tests (#13778) test: DisplayQueryButton (#13750) Fixing condition around left margin for dashboard layout. Fixes #13863 (#13905) Revert "fix: select table overlay (#13694)" (#13901) test: Adds tests to the OptionControls component (#13729) test: DatasourceControl (#13605) tests for function handleScroll (#13896) test: Adds tests to the CustomFrame component (#13675) test: Adds tests to the AdvancedFrame component (#13664) test: DataTableControl (#13668) ...
lyndsiWilliams
pushed a commit
to preset-io/superset
that referenced
this pull request
Apr 7, 2021
allanco91
pushed a commit
to allanco91/superset
that referenced
this pull request
May 21, 2021
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes
PropertiesModal_specerror in Node 15.In Node 15 they changed the way to handle promise rejections. In previous versions of Node, promise rejections are handled as warnings, so the test pass but that doesn't mean that the test is correct. I fixed the code that was causing the promise rejection and now the test also passes in Node 15.
TEST PLAN
1 - Execute
PropertiesModal_spectests2 - All tests should pass
@rusackas @simcha90
ADDITIONAL INFORMATION