Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: DisplayQueryButton #13750

Merged
merged 4 commits into from
Apr 1, 2021
Merged

test: DisplayQueryButton #13750

merged 4 commits into from
Apr 1, 2021

Conversation

yardz
Copy link
Contributor

@yardz yardz commented Mar 23, 2021

SUMMARY

Tests for DisplayQueryButton

  • Moved to own folder
  • Creating tests for the component

@codecov
Copy link

codecov bot commented Mar 23, 2021 •
edited
Loading

Codecov Report

Merging #13750 (c4f7ce5) into master (5b79f84) will increase coverage by 0.07%.
The diff coverage is 73.25%.

❗ Current head c4f7ce5 differs from pull request most recent head 237883d. Consider uploading reports for the commit 237883d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13750      +/-   ##
==========================================
+ Coverage   77.45%   77.53%   +0.07%     
==========================================
  Files         933      934       +1     
  Lines       47144    47249     +105     
  Branches     5848     5892      +44     
==========================================
+ Hits        36516    36634     +118     
+ Misses      10485    10471      -14     
- Partials      143      144       +1
Flag Coverage Δ
cypress 56.07% <27.05%> (-0.28%) ⬇️
javascript 63.91% <70.56%> (+0.44%) ⬆️
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rset-frontend/src/SqlLab/components/QueryTable.jsx 66.66% <ø> (ø)
...erset-frontend/src/SqlLab/components/SqlEditor.jsx 56.01% <ø> (ø)
superset-frontend/src/chart/chartReducer.ts 66.19% <ø> (+1.81%) ⬆️
superset-frontend/src/common/components/index.tsx 100.00% <ø> (ø)
...perset-frontend/src/components/FormLabel/index.tsx 100.00% <ø> (ø)
...rset-frontend/src/components/ProgressBar/index.tsx 100.00% <ø> (ø)
...et-frontend/src/components/TableView/TableView.tsx 96.42% <ø> (ø)
...src/dashboard/components/gridComponents/Header.jsx 100.00% <ø> (+2.63%) ⬆️
superset-frontend/src/dashboard/index.jsx 100.00% <ø> (+36.36%) ⬆️
...tasourcePanel/DatasourcePanelDragWrapper/index.tsx 100.00% <ø> (ø)
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b79f84...237883d. Read the comment docs.

@yardz yardz closed this Mar 23, 2021
@yardz yardz reopened this Mar 23, 2021
geido
geido reviewed Mar 24, 2021
View reviewed changes
Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from a small nit and what Michael has suggested

superset-frontend/src/explore/components/DisplayQueryButton/DisplayQueryButton.test.tsx Show resolved Hide resolved
yardz and others added 2 commits March 26, 2021 11:22
@yardz @michael-s-molina
Update superset-frontend/src/explore/components/DisplayQueryButton/Di…
264c005 
…splayQueryButton.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
@yardz @michael-s-molina
Update superset-frontend/src/explore/components/DisplayQueryButton/Di…
237883d 
…splayQueryButton.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
@yardz
Copy link
Contributor Author

yardz commented Mar 26, 2021

@rusackas can you look here please

@junlincc
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@junlincc Ephemeral environment spinning up at http://52.36.47.201:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

rusackas
rusackas approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@rusackas rusackas merged commit 1dbc149 into apache:master Apr 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2021

Ephemeral environment shutdown and build artifacts deleted.

amitmiran137 pushed a commit that referenced this pull request Apr 2, 2021
Merge branch 'master' into feat/dashboard_extra_jwt
308c659 
* master: (26 commits)
  chore: bump to new superset-ui version (#13932)
  fix: do not run containers as root by default in Helm chart (#13917)
  feat(explore): adhoc column formatting for Table chart (#13758)
  fix(sqla-query): order by aggregations in Presto and Hive (#13739)
  feat(alert/report): add ALERTS_ATTACH_REPORTS feature flags + feature (#13894)
  test: Fixes PropertiesModal_spec (#13548)
  fix: Pin Prophet dependency after breaking changes (#13852)
  test: Adds tests to dnd controls (#13650)
  test: Adds tests to the AnnotationLayer component (#13748)
  test: Refactor and enhance tests for the Explore DatasourcePanel Component (#13799)
  Add tests (#13778)
  test: DisplayQueryButton (#13750)
  Fixing condition around left margin for dashboard layout. Fixes #13863 (#13905)
  Revert "fix: select table overlay (#13694)" (#13901)
  test: Adds tests to the OptionControls component (#13729)
  test: DatasourceControl (#13605)
  tests for function handleScroll (#13896)
  test: Adds tests to the CustomFrame component (#13675)
  test: Adds tests to the AdvancedFrame component (#13664)
  test: DataTableControl (#13668)
  ...
lyndsiWilliams pushed a commit to preset-io/superset that referenced this pull request Apr 7, 2021
@yardz @michael-s-molina @lyndsiWilliams
test: DisplayQueryButton (apache#13750)
211897e 
* Tests for DisplayQueryButton component

* add factories to props and fetch-mock

* Update superset-frontend/src/explore/components/DisplayQueryButton/DisplayQueryButton.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/DisplayQueryButton/DisplayQueryButton.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@yardz @michael-s-molina
test: DisplayQueryButton (apache#13750)
a147c2b 
* Tests for DisplayQueryButton component

* add factories to props and fetch-mock

* Update superset-frontend/src/explore/components/DisplayQueryButton/DisplayQueryButton.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/DisplayQueryButton/DisplayQueryButton.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geido geido geido left review comments

@rusackas rusackas rusackas approved these changes

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L test:component 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yardz @junlincc @rusackas @geido @michael-s-molina @mistercrunch