fix(dependency): Pin pystan after breaking prophet install

[EBoisseauSierra]

SUMMARY

Prophet is heavily dependent on Pystan: https://facebook.github.io/prophet/docs/installation.html

Pystan has recently (2021-03-25) release its v3.0.0.

This release is not backward compatible and breaks fbprophet: facebook/prophet#1856

(Indeed, fbprophet 0.6 specifies pystan>=2.14 — but doesn't restrict upgrading to next major release: https://github.com/facebook/prophet/blob/0.6/python/requirements.txt#L3)

So we need to pin pystan to the lastest non 3.x release, while fbprophet fixes the dependency on their side.

TEST PLAN

pip install '.[prophet]'?

ADDITIONAL INFORMATION

• Has associated issue: Fixes pip install '.[prophet]' is broken, due to pystan #13851
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[EBoisseauSierra]

Note: fbprophet's team said 3 days ago:

We're pushing a new release with the updated pinned version very soon.

[junlincc]

Thanks Étienne for surfacing it! so much going on we lost track of updating/maintaining this feature. @EBoisseauSierra would you like to 'own' this piece and keep it in good shape going forward? 😉

[codecov]

Codecov Report

Merging #13852 (a73bdb5) into master (467848d) will increase coverage by 1.73%.
The diff coverage is 69.69%.

❗ Current head a73bdb5 differs from pull request most recent head 83ed5fd. Consider uploading reports for the commit 83ed5fd to get more accurate results

@@            Coverage Diff             @@
##           master   #13852      +/-   ##
==========================================
+ Coverage   75.56%   77.30%   +1.73%     
==========================================
  Files         935      938       +3     
  Lines       47275    47558     +283     
  Branches     5883     6005     +122     
==========================================
+ Hits        35725    36765    +1040     
+ Misses      11375    10646     -729     
+ Partials      175      147      -28     

Flag	Coverage Δ
cypress	56.02% <47.50%> (+8.32%)	⬆️
hive	80.29% <70.00%> (+<0.01%)	⬆️
mysql	80.60% <70.00%> (+<0.01%)	⬆️
postgres	80.63% <70.00%> (+<0.01%)	⬆️
presto	80.29% <70.00%> (-0.01%)	⬇️
python	81.14% <70.00%> (-0.01%)	⬇️
sqlite	80.19% <70.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset-frontend/src/views/CRUD/alert/types.ts	100.00% <ø> (ø)
superset/reports/logs/api.py	95.45% <ø> (ø)
superset/tasks/scheduler.py	0.00% <0.00%> (ø)
superset/views/core.py	75.66% <0.00%> (ø)
...veFilters/FilterBar/FilterControls/FilterValue.tsx	73.03% <50.00%> (+0.81%)	⬆️
...erset-frontend/src/SqlLab/components/ResultSet.tsx	47.12% <60.00%> (-21.82%)	⬇️
...ters/FiltersConfigModal/FiltersConfigForm/state.ts	75.92% <69.23%> (+23.29%)	⬆️
...tersConfigModal/FiltersConfigForm/DefaultValue.tsx	80.55% <100.00%> (+4.69%)	⬆️
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx	94.18% <100.00%> (+6.68%)	⬆️
.../src/explore/components/controls/SelectControl.jsx	93.75% <100.00%> (+4.46%)	⬆️
... and 127 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 467848d...83ed5fd. Read the comment docs.

[etr2460]

will prophet 1.0.1 work with Superset? if not, then this change makes sense. otherwise, let's bump prophet instead

[EBoisseauSierra]

will prophet 1.0.1 work with Superset?

You are right that it's a better thing to do.

Unfortunately, I hadn't much time to extensively test bumping fbprophet<0.7 to prophet>=1.01, so — especially as I'm not so familiar with the codebase and that I couldn't find in 7af8b2b3f why was the <0.7 constraint applied — I preferred shipping a quick fix first.

I will test bumping [fb]prophet instead, but if it passes test, I'd still appreciate some external sanity check as I couldn't do much more than blindly relying on them.

P.S.: FYI, I'm currently testing it on https://github.com/EBoisseauSierra/superset/tree/bump-prophet

would you like to 'own' this piece and keep it in good shape going forward?

Thanks for offering. I would be happy to monitor when Prophet fixes its dependency, to revert this change; yet I'm afraid I am not familiar enough with prophet to properly “own” the extension.

[etr2460]

This lgtm, thanks for pulling in the dep pinning patch from upstream

[villebro]

Thanks for fixing this - I noticed the other day I had trouble getting prophet to work but didn't have time to investigate, I'm happy I was able to freeride on your fix! :)