Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "fix: select table overlay" #13901

Merged
merged 1 commit into from Apr 1, 2021

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Apr 1, 2021

Reverts #13694 and fixes the issue being fixed in #13858 a bit faster.

Test plan
CI

to: @AAfghahi @ktmud @graceguo-supercat

@etr2460 etr2460 changed the title Revert "fix: select table overlay" fix: Revert "fix: select table overlay" Apr 1, 2021
Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #13901 (4b2d404) into master (28fe6e0) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 4b2d404 differs from pull request most recent head 6ad28ef. Consider uploading reports for the commit 6ad28ef to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13901      +/-   ##
==========================================
- Coverage   77.43%   77.36%   -0.07%     
==========================================
  Files         935      938       +3     
  Lines       47317    47494     +177     
  Branches     5904     5952      +48     
==========================================
+ Hits        36641    36745     +104     
- Misses      10534    10607      +73     
  Partials      142      142              
Flag Coverage Δ
cypress 56.02% <ø> (-0.01%) ⬇️
javascript 64.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/components/DatabaseSelector/index.tsx 91.66% <ø> (ø)
...et-frontend/src/components/TableSelector/index.tsx 84.92% <ø> (ø)
...ntend/src/dashboard/components/dnd/handleScroll.ts 26.66% <0.00%> (-20.01%) ⬇️
...frontend/src/explore/components/OptionControls.tsx 64.89% <0.00%> (-2.13%) ⬇️
...plore/components/controls/OptionControls/index.tsx 64.77% <0.00%> (ø)
...re/components/controls/DatasourceControl/index.jsx 61.84% <0.00%> (ø)
...src/dashboard/components/dnd/handleScroll/index.ts 38.46% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28fe6e0...6ad28ef. Read the comment docs.

@etr2460 etr2460 merged commit 5315d2c into master Apr 1, 2021
amitmiran137 added a commit that referenced this pull request Apr 2, 2021
* master: (26 commits)
  chore: bump to new superset-ui version (#13932)
  fix: do not run containers as root by default in Helm chart (#13917)
  feat(explore): adhoc column formatting for Table chart (#13758)
  fix(sqla-query): order by aggregations in Presto and Hive (#13739)
  feat(alert/report): add ALERTS_ATTACH_REPORTS feature flags + feature (#13894)
  test: Fixes PropertiesModal_spec (#13548)
  fix: Pin Prophet dependency after breaking changes (#13852)
  test: Adds tests to dnd controls (#13650)
  test: Adds tests to the AnnotationLayer component (#13748)
  test: Refactor and enhance tests for the Explore DatasourcePanel Component (#13799)
  Add tests (#13778)
  test: DisplayQueryButton (#13750)
  Fixing condition around left margin for dashboard layout. Fixes #13863 (#13905)
  Revert "fix: select table overlay (#13694)" (#13901)
  test: Adds tests to the OptionControls component (#13729)
  test: DatasourceControl (#13605)
  tests for function handleScroll (#13896)
  test: Adds tests to the CustomFrame component (#13675)
  test: Adds tests to the AdvancedFrame component (#13664)
  test: DataTableControl (#13668)
  ...
henryyeh pushed a commit to preset-io/superset that referenced this pull request Apr 6, 2021
lyndsiWilliams pushed a commit to preset-io/superset that referenced this pull request Apr 7, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@rusackas rusackas deleted the revert-13694-datasetTableSelector branch January 30, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants