Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] refactor: replace "csv" with "file" used in common (excel) upload cases #13805

Closed
wants to merge 1 commit into from
Closed

Conversation

cemremengu
Copy link
Contributor

This is just the tip of the iceberg. allow_csv_upload is almost everywhere in codebase including the database. Not sure the effects of renaming that. If someone can assist me in creating a db migration I can also do that.

image

ADDITIONAL INFORMATION

  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.

@cemremengu cemremengu changed the title refactor: rename methods with "csv" to "file" refactor: replace "csv" with "file" used in common (excel) upload cases Mar 26, 2021
@cemremengu cemremengu changed the title refactor: replace "csv" with "file" used in common (excel) upload cases WIP: refactor: replace "csv" with "file" used in common (excel) upload cases Mar 26, 2021
@cemremengu cemremengu changed the title WIP: refactor: replace "csv" with "file" used in common (excel) upload cases [WIP] refactor: replace "csv" with "file" used in common (excel) upload cases Mar 26, 2021
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #13805 (73e8901) into master (e61f5a9) will decrease coverage by 0.14%.
The diff coverage is 77.77%.

❗ Current head 73e8901 differs from pull request most recent head d64d701. Consider uploading reports for the commit d64d701 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13805      +/-   ##
==========================================
- Coverage   77.51%   77.37%   -0.15%     
==========================================
  Files         934      934              
  Lines       47250    47250              
  Branches     5881     5881              
==========================================
- Hits        36628    36560      -68     
- Misses      10478    10546      +68     
  Partials      144      144              
Flag Coverage Δ
cypress 56.02% <ø> (-0.03%) ⬇️
hive ?
mysql 80.58% <77.77%> (ø)
postgres 80.61% <77.77%> (ø)
presto 80.28% <77.77%> (+0.13%) ⬆️
python 80.86% <77.77%> (-0.12%) ⬇️
sqlite 80.17% <77.77%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/database/forms.py 88.88% <0.00%> (ø)
superset/models/core.py 89.37% <100.00%> (ø)
superset/views/core.py 75.62% <100.00%> (ø)
superset/views/database/validators.py 84.21% <100.00%> (ø)
superset/views/database/views.py 87.56% <100.00%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 74.23% <0.00%> (-16.54%) ⬇️
...et-frontend/src/dashboard/components/Dashboard.jsx 85.26% <0.00%> (-4.22%) ⬇️
superset/db_engine_specs/presto.py 88.70% <0.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e61f5a9...d64d701. Read the comment docs.

@stale
Copy link

stale bot commented Jun 11, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Jun 11, 2021
@villebro
Copy link
Member

Closing this PR, as this work has already been implemented in #16756

@villebro villebro closed this Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive Inactive for >= 30 days size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants