Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: White space between Chart and Data panel in Explore #14495

Merged
merged 2 commits into from
May 10, 2021
Merged

fix: White space between Chart and Data panel in Explore #14495

merged 2 commits into from
May 10, 2021

Conversation

geido
Copy link
Member

@geido geido commented May 5, 2021

SUMMARY

Fixes #12707

BEFORE

before_heatmap

AFTER

after_heatmap

TEST PLAN

  1. Open a chart in Explore
  2. Observe the white space between the chart and the data panel
  3. Observe the white space between the Data panel title and the Data panel tabs

before_heatmap

ADDITIONAL INFORMATION

  • Has associated issue: [explore]cosmetic improvement suggestions  #12707
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@geido
Copy link
Member Author

geido commented May 5, 2021

@junlincc @rusackas

@junlincc
Copy link
Member

junlincc commented May 5, 2021

@geido Much better! thank you.

@rusackas
Copy link
Member

rusackas commented May 5, 2021

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2021

@rusackas Ephemeral environment spinning up at http://52.37.161.164:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@rusackas rusackas requested review from kgabryje and rusackas May 5, 2021 22:43
rusackas
rusackas approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

michael-s-molina
michael-s-molina approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

villebro
villebro approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better!

@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #14495 (bf20538) into master (b030c98) will increase coverage by 0.00%.
The diff coverage is 50.00%.

❗ Current head bf20538 differs from pull request most recent head f7cca5f. Consider uploading reports for the commit f7cca5f to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           master   #14495    +/-   ##
========================================
  Coverage   77.12%   77.12%            
========================================
  Files         953      953            
  Lines       48189    48190     +1     
  Branches     6051     5626   -425     
========================================
+ Hits        37166    37167     +1     
  Misses      10822    10822            
  Partials      201      201
Flag Coverage Δ
javascript 71.94% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nd/src/explore/components/DataTablesPane/index.tsx 88.88% <ø> (ø)
...ntend/src/explore/components/ExploreChartPanel.jsx 17.14% <50.00%> (+1.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b030c98...f7cca5f. Read the comment docs.

@junlincc junlincc added the need:merge The PR is ready to be merged label May 10, 2021
@junlincc junlincc self-requested a review May 10, 2021 20:01
junlincc
junlincc approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@junlincc junlincc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

product sign-off thanks for the PR!

@pkdotson pkdotson merged commit e21beb7 into apache:master May 10, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@rusackas rusackas added the bash! label May 12, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
@geido
fix: White space between Chart and Data panel in Explore (apache#14495)
50447ca 
* Adjust white space

* Adjust chart padding
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@geido
fix: White space between Chart and Data panel in Explore (apache#14495)
08df2ec 
* Adjust white space

* Adjust chart padding
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@geido
fix: White space between Chart and Data panel in Explore (apache#14495)
f850834 
* Adjust white space

* Adjust chart padding
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@junlincc junlincc junlincc approved these changes

@villebro villebro villebro approved these changes

@rusackas rusackas rusackas approved these changes

@kgabryje kgabryje Awaiting requested review from kgabryje

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:merge The PR is ready to be merged size/XS 🚢 1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[explore]cosmetic improvement suggestions
7 participants
@geido @junlincc @rusackas @villebro @michael-s-molina @mistercrunch @pkdotson