Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update kubernetes.mdx #14512

Merged
merged 5 commits into from
Nov 26, 2021
Merged

fix: update kubernetes.mdx #14512

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8da7292
Update kubernetes.mdx
shicholas May 7, 2021
0314091
added changes per @mvoitko's suggestions
shicholas Sep 6, 2021
a5dd8c5
update k8 mdx
shicholas Nov 23, 2021
0597c35
Update docs/src/pages/docs/installation/kubernetes.mdx
shicholas Nov 24, 2021
3a5dd6d
Update docs/src/pages/docs/installation/kubernetes.mdx
shicholas Nov 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 8 additions & 15 deletions docs/src/pages/docs/installation/kubernetes.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,25 +94,18 @@ postgresql:

#### Dependencies

You can specify pip packages to be installed before startup, e.g. to install extra database drivers:
You can specify pip packages to be installed before startup. The following example installs the Big Query and Elasticsearch database drivers so that you can connect to those datasources in your Superset installation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's include the comment on the values config file:

# Install additional packages and do any other bootstrap configuration in this script
# For production clusters it's recommended to build own image with this step done in CI

Since we should not encourage the use of a bootstrap script to install OS or python packages

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.


```yaml
additionalRequirements:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additionalRequiremnts are no longer supported value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no this broke, please see #14188 and #13917. This PR may be a moot point if this chart is released up, see #14188 (comment) which is a comment from 14 days ago.

- psycopg2
- redis
- elasticsearch-dbapi
- pymssql
- gsheetsdb
# Force verstion to work around https://github.com/betodealmeida/gsheets-db-api/issues/15
- moz-sql-parser==4.9.21002
# For OAuth
- Authlib
# For webdriver / reports
- gevent
bootstrapScript: |
#!/bin/bash
pip install psycopg2==2.8.5 \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which versions are supported?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are, I think the important thing here is to get a working demo, it should be up to the end-user to determine what packages they want to install in their own superset install.

redis==3.2.1 \
pybigquery==2.26.0 \
elasticsearch-dbapi==0.2.5 &&\
if [ ! -f ~/bootstrap ]; then echo "Running Superset with uid {{ .Values.runAsUser }}" > ~/bootstrap; fi
```

__WARNING__: The list will replace the default one from the default `values.yaml` entirely, not _add_ to it...

#### superset_config.py

The default `superset_config.py` is fairly minimal and you will very likely need to extend it. This is done by specifying one or more key/value entries in `configOverrides`, e.g.:
Expand Down