fix: DB parameter validation API #14636
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
I was testing the new validation API for DB parameters and realized that it would fail in certain cases because the SIP-41 handler uses
dataclasses.asdict
, which doesn't play nice withdefaultdict
(https://bugs.python.org/issue35540).I added custom code to handle the payload with
defaultdict
in case there's a validation error, converting to a normal dict.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
Added a unit test covering the regression.
ADDITIONAL INFORMATION