Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add DASHBOARD_FILTERS_EXPERIMENTAL ff to BE default value #15417

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

amitmiran137
Copy link
Member

SUMMARY

this flag was introduced in the frontend but default value is missing in the BE
#14814

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #15417 (b2332b9) into master (f53b2c6) will decrease coverage by 0.22%.
The diff coverage is n/a.

❗ Current head b2332b9 differs from pull request most recent head 8fe89ec. Consider uploading reports for the commit 8fe89ec to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15417      +/-   ##
==========================================
- Coverage   77.22%   76.99%   -0.23%     
==========================================
  Files         975      975              
  Lines       50634    50634              
  Branches     6222     6222              
==========================================
- Hits        39104    38988     -116     
- Misses      11319    11435     +116     
  Partials      211      211              
Flag Coverage Δ
hive ?
mysql 81.71% <ø> (ø)
postgres 81.73% <ø> (ø)
presto ?
python 81.81% <ø> (-0.44%) ⬇️
sqlite 81.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 91.15% <ø> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 69.20% <0.00%> (-17.21%) ⬇️
superset/db_engine_specs/presto.py 83.36% <0.00%> (-6.53%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 88.22% <0.00%> (-1.65%) ⬇️
superset/db_engine_specs/base.py 87.97% <0.00%> (-0.41%) ⬇️
superset/models/core.py 89.76% <0.00%> (-0.27%) ⬇️
superset/utils/core.py 88.97% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f53b2c6...8fe89ec. Read the comment docs.

@amitmiran137 amitmiran137 merged commit 8205ea5 into master Jun 28, 2021
mvoitko pushed a commit to mvoitko/superset that referenced this pull request Jun 28, 2021
amitmiran137 added a commit that referenced this pull request Jul 4, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@rusackas rusackas deleted the chore/missing_ff branch January 30, 2023 19:21
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v1.3 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants