chore: Homepage cleanup #14823

pkdotson · 2021-05-25T19:04:53Z

SUMMARY

This is follow up to #14695. This pr address the comments and ensures that the the sticky tabs works when examples tabs is rendered and not viewed.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

load a brand new instance of superset and test. The examples tabs should be set first if there is no active tab set in local state or viewed is set in previous state.

ADDITIONAL INFORMATION

Has associated issue:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

codecov · 2021-05-25T19:34:21Z

Codecov Report

Merging #14823 (ef53a50) into master (53df152) will decrease coverage by 0.01%.
The diff coverage is 75.71%.

@@            Coverage Diff             @@
##           master   #14823      +/-   ##
==========================================
- Coverage   77.50%   77.49%   -0.02%     
==========================================
  Files         968      969       +1     
  Lines       49880    49902      +22     
  Branches     6374     6383       +9     
==========================================
+ Hits        38659    38671      +12     
- Misses      11019    11029      +10     
  Partials      202      202

Flag	Coverage Δ
javascript	`72.37% <75.71%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...perset-frontend/src/views/CRUD/welcome/Welcome.tsx	`81.30% <65.00%> (-2.57%)`	⬇️
...-frontend/src/views/CRUD/welcome/ActivityTable.tsx	`78.43% <70.58%> (-1.17%)`	⬇️
...set-frontend/src/views/CRUD/welcome/ChartTable.tsx	`77.94% <78.57%> (+3.31%)`	⬆️
...frontend/src/views/CRUD/welcome/DashboardTable.tsx	`66.25% <83.33%> (+1.96%)`	⬆️
superset-frontend/src/views/CRUD/storageKeys.ts	`100.00% <100.00%> (ø)`
superset-frontend/src/views/CRUD/types.ts	`100.00% <100.00%> (ø)`
superset-frontend/src/views/CRUD/utils.tsx	`63.86% <0.00%> (-6.73%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53df152...ef53a50. Read the comment docs.

superset-frontend/src/views/CRUD/utils.tsx

superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx

geido

LGTM on the basis of the code. I have asked to launch a testenv up for some manual testing

pkdotson · 2021-05-27T16:42:06Z

/testenv up

github-actions · 2021-05-27T17:34:57Z

@pkdotson Ephemeral environment spinning up at http://54.212.102.11:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

kgabryje · 2021-05-28T13:17:35Z

I think I found a bug - I don't have any favourite dashboards, but when I reload, dashboards from "Mine" tab show up in "Favourite" tab.
https://user-images.githubusercontent.com/15073128/119989659-b8843000-bfc7-11eb-9100-25611547f555.mov

superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx

kgabryje · 2021-05-31T12:07:49Z

/testenv up

superset-frontend/src/views/CRUD/welcome/ChartTable.tsx

github-actions · 2021-05-31T12:19:21Z

@kgabryje Ephemeral environment creation failed. Please check the Actions logs for details.

suddjian · 2021-06-01T23:11:15Z

superset-frontend/src/views/CRUD/storageKeys.ts

+// storage keys for welcome page sticky tabs..
+export const HOMEPAGE_CHART_FILTER = 'homepage_chart_filter';
+export const HOMEPAGE_ACTIVITY_FILTER = 'homepage_activity_filter';
+export const HOMEPAGE_DASHBOARD_FILTER = 'homepage_dashboard_filter';


constants file, nice!

pkdotson · 2021-06-10T22:53:32Z

/testenv up

github-actions · 2021-06-10T22:57:51Z

@pkdotson Ephemeral environment spinning up at http://54.149.201.178:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx

superset-frontend/src/views/CRUD/welcome/ChartTable.tsx

suddjian

Approved with suggestions

superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx

superset-frontend/src/views/CRUD/welcome/DashboardTable.tsx

superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx

…omepage-cleanup

github-actions · 2021-06-12T01:48:01Z

Ephemeral environment shutdown and build artifacts deleted.

* initial commit * update welcome * fix lint * add enum * more choring * fix lint * redo logic for api stick api calls * fix test * fix chart test * lint fix and remove unused code * fix flicker and add suggestions * lint * fix test * add suggestions * add suggestions and fix test * revert packagelock * fix space

pkdotson added 2 commits May 25, 2021 13:50

initial commit

c16e22e

update welcome

3fc9f7f

superset-github-bot bot added the preset-io label May 25, 2021

pull-request-size bot added the size/M label May 25, 2021

pkdotson requested review from kgabryje and junlincc May 25, 2021 19:05

fix lint

026524a

pkdotson requested a review from nytai May 25, 2021 19:22

geido requested changes May 26, 2021

View reviewed changes

superset-frontend/src/views/CRUD/utils.tsx Outdated Show resolved Hide resolved

superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx Outdated Show resolved Hide resolved

pkdotson added 3 commits May 27, 2021 10:56

add enum

4dac92b

more choring

47c718a

fix lint

a0149ee

geido approved these changes May 27, 2021

View reviewed changes

kgabryje reviewed May 28, 2021

View reviewed changes

superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx Outdated Show resolved Hide resolved

This was referenced May 28, 2021

[home page] favorite tab in chart section is not showing favorite chart #14886

Closed

[home page] favorite tab in dashboard section is not showing favorite dashboard #14887

Closed

redo logic for api stick api calls

3d85ced

pull-request-size bot added size/L and removed size/M labels May 28, 2021

fix test

7ca386d

kgabryje reviewed May 31, 2021

View reviewed changes

superset-frontend/src/views/CRUD/welcome/ChartTable.tsx Outdated Show resolved Hide resolved

suddjian reviewed Jun 1, 2021

View reviewed changes

pkdotson added 2 commits June 10, 2021 11:34

fix chart test

f501e31

lint fix and remove unused code

f19ccbb

pkdotson added 3 commits June 10, 2021 16:43

fix flicker and add suggestions

80f0836

lint

c9b1a66

fix test

66e4ebc

apache deleted a comment from github-actions bot Jun 10, 2021

suddjian reviewed Jun 11, 2021

View reviewed changes

superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx Show resolved Hide resolved

suddjian reviewed Jun 11, 2021

View reviewed changes

superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx Outdated Show resolved Hide resolved

suddjian reviewed Jun 11, 2021

View reviewed changes

superset-frontend/src/views/CRUD/welcome/ChartTable.tsx Outdated Show resolved Hide resolved

suddjian approved these changes Jun 11, 2021

View reviewed changes

suddjian reviewed Jun 11, 2021

View reviewed changes

superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx Outdated Show resolved Hide resolved

add suggestions

baa195d

nytai reviewed Jun 11, 2021

View reviewed changes

superset-frontend/src/views/CRUD/welcome/DashboardTable.tsx Outdated Show resolved Hide resolved

nytai reviewed Jun 11, 2021

View reviewed changes

superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx Outdated Show resolved Hide resolved

pkdotson added 4 commits June 11, 2021 18:05

add suggestions and fix test

b5f2e96

Merge branch 'master' of https://github.com/preset-io/superset into h…

cbe6225

…omepage-cleanup

revert packagelock

c445839

fix space

ef53a50

pkdotson merged commit 8e6a5a6 into apache:master Jun 12, 2021

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Homepage cleanup #14823

chore: Homepage cleanup #14823

pkdotson commented May 25, 2021

codecov bot commented May 25, 2021 •

edited

Loading

geido left a comment •

edited

Loading

pkdotson commented May 27, 2021

github-actions bot commented May 27, 2021

kgabryje commented May 28, 2021

kgabryje commented May 31, 2021

github-actions bot commented May 31, 2021

suddjian Jun 1, 2021

pkdotson commented Jun 10, 2021

github-actions bot commented Jun 10, 2021

suddjian left a comment

github-actions bot commented Jun 12, 2021

chore: Homepage cleanup #14823

chore: Homepage cleanup #14823

Conversation

pkdotson commented May 25, 2021

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

codecov bot commented May 25, 2021 • edited Loading

Codecov Report

geido left a comment • edited Loading

Choose a reason for hiding this comment

pkdotson commented May 27, 2021

github-actions bot commented May 27, 2021

kgabryje commented May 28, 2021

kgabryje commented May 31, 2021

github-actions bot commented May 31, 2021

suddjian Jun 1, 2021

Choose a reason for hiding this comment

pkdotson commented Jun 10, 2021

github-actions bot commented Jun 10, 2021

suddjian left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 12, 2021

codecov bot commented May 25, 2021 •

edited

Loading

geido left a comment •

edited

Loading