Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Big Query Edit Form #14850

Merged
merged 4 commits into from
May 26, 2021
Merged

fix: Big Query Edit Form #14850

merged 4 commits into from
May 26, 2021

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented May 26, 2021

SUMMARY

With new DatabaseModal we aren't able to edit, users are getting a fatal error due to missing encrypted_extra when building the uri

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hughhhh
Copy link
Member Author

hughhhh commented May 26, 2021

@yousoph
Copy link
Member

yousoph commented May 26, 2021

🏷️ 2021.21

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #14850 (5e10341) into master (e466066) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14850      +/-   ##
==========================================
- Coverage   77.61%   77.53%   -0.08%     
==========================================
  Files         963      963              
  Lines       49246    49247       +1     
  Branches     6197     6197              
==========================================
- Hits        38224    38186      -38     
- Misses      10821    10860      +39     
  Partials      201      201              
Flag Coverage Δ
hive 81.31% <33.33%> (-0.01%) ⬇️
javascript 72.48% <ø> (ø)
mysql 81.59% <100.00%> (+<0.01%) ⬆️
postgres 81.62% <100.00%> (+<0.01%) ⬆️
presto ?
python 81.99% <100.00%> (-0.15%) ⬇️
sqlite 81.23% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/bigquery.py 90.15% <ø> (ø)
superset/db_engine_specs/base.py 88.30% <100.00%> (ø)
superset/models/core.py 89.73% <100.00%> (-0.24%) ⬇️
superset/db_engine_specs/presto.py 84.42% <0.00%> (-5.48%) ⬇️
superset/connectors/sqla/models.py 88.33% <0.00%> (-1.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e466066...5e10341. Read the comment docs.

@hughhhh hughhhh merged commit ae8378a into master May 26, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* fix big quert edit form

* fix test

* fix api test

* fix test
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* fix big quert edit form

* fix test

* fix api test

* fix test
@rusackas rusackas deleted the hugh/fix-big-edit branch January 30, 2023 19:21
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* fix big quert edit form

* fix test

* fix api test

* fix test
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants