Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bulk Select X Button Alignment #14870

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

lyndsiWilliams
Copy link
Member

SUMMARY

On all crud views with bulk select, the X button has been aligned so that it's centered vertically.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

  • Navigate to the following areas in Superset:
    • Datasets
    • Charts
    • Dashboards
    • Saved Queries
    • Alerts
    • Reports
  • Click the "Bulk Select" button
  • Observe the aligned close icon to the right

ADDITIONAL INFORMATION

  • Has associated issue: Clubhouse Ticket
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@lyndsiWilliams lyndsiWilliams marked this pull request as ready for review May 27, 2021 14:05
@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #14870 (1f6be43) into master (bd2c087) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14870      +/-   ##
==========================================
- Coverage   77.61%   77.60%   -0.02%     
==========================================
  Files         963      963              
  Lines       49247    49285      +38     
  Branches     6197     6203       +6     
==========================================
+ Hits        38225    38246      +21     
- Misses      10821    10838      +17     
  Partials      201      201              
Flag Coverage Δ
javascript 72.45% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rset-frontend/src/components/ListView/ListView.tsx 96.15% <100.00%> (+0.03%) ⬆️
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 68.37% <0.00%> (-4.27%) ⬇️
...nfigModal/FiltersConfigForm/getControlItemsMap.tsx 97.05% <0.00%> (-2.95%) ⬇️
...mponents/nativeFilters/FiltersConfigModal/utils.ts 67.94% <0.00%> (-0.81%) ⬇️
...veFilters/FilterBar/FilterControls/FilterValue.tsx 67.44% <0.00%> (ø)
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 95.18% <0.00%> (+0.30%) ⬆️
...rontend/src/visualizations/FilterBox/FilterBox.jsx 57.32% <0.00%> (+0.72%) ⬆️
...c/filters/components/Select/SelectFilterPlugin.tsx 68.18% <0.00%> (+3.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd2c087...1f6be43. Read the comment docs.

@hughhhh hughhhh self-requested a review June 8, 2021 17:09
@hughhhh hughhhh merged commit 6cc179b into apache:master Jun 8, 2021
@lyndsiWilliams lyndsiWilliams deleted the lyndsi/align-bulk-select-x branch October 15, 2021 01:32
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants