-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aarch64): Bump pyarrow version to 4.0.1 #14891
Conversation
Thanks @danielewood , this is awesome news! I'll review/test this pronto |
Codecov Report
@@ Coverage Diff @@
## master #14891 +/- ##
==========================================
- Coverage 77.53% 77.35% -0.19%
==========================================
Files 963 969 +6
Lines 49247 50017 +770
Branches 6197 6432 +235
==========================================
+ Hits 38186 38689 +503
- Misses 10860 11123 +263
- Partials 201 205 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This seems to be the relevant change: |
Tagging @robdiciuccio for review. This seems to work fine for me. While this is a x.0.0 release, it's already been out for a month, and we're currently on 3.0.0 anyway, so I don't see major risk in bumping. However, for orgs that are using Arrow serialized data in their caches, we should make sure that the |
@danielewood I noticed |
/testenv up |
@robdiciuccio Ephemeral environment spinning up at http://35.162.119.13:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me in the test env. I also don't see anything about serialization format changes in the release notes, so I think this is good as-is.
Ephemeral environment shutdown and build artifacts deleted. |
* Bump pyarrow to v4 for aarch64 compatibility. * Update base.txt * Bump to 4.0.1
* Bump pyarrow to v4 for aarch64 compatibility. * Update base.txt * Bump to 4.0.1
* Bump pyarrow to v4 for aarch64 compatibility. * Update base.txt * Bump to 4.0.1
SUMMARY
Could not build docker image on arm64 (Oracle Cloud A1) with current master. Bumped pyarrow from 3.0.0 to 4.0.0 and now it builds with no issues.
This patch means that superset can probably now run on a 64bit Raspberry Pi 4.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
Ran all the integration tests and E2E tests with no issues.
Currently running a test instance on aarch64 and amd64 with these changes, I have yet to find anything broken.
ADDITIONAL INFORMATION