Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update documentation for frontend feature flags #15093

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Jun 10, 2021

SUMMARY

This was out of date, updating

TESTING INSTRUCTIONS

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

to: @m-ajay @graceguo-supercat @ktmud

@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #15093 (005d6a5) into master (f8b270d) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15093      +/-   ##
==========================================
+ Coverage   77.53%   77.61%   +0.08%     
==========================================
  Files         967      967              
  Lines       49740    49740              
  Branches     6351     6351              
==========================================
+ Hits        38565    38606      +41     
+ Misses      10973    10932      -41     
  Partials      202      202              
Flag Coverage Δ
hive 81.44% <ø> (ø)
javascript 72.44% <ø> (ø)
mysql 81.70% <ø> (ø)
postgres 81.73% <ø> (ø)
presto 81.43% <ø> (?)
python 82.25% <ø> (+0.15%) ⬆️
sqlite 81.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/models/core.py 90.02% <0.00%> (+0.26%) ⬆️
superset/connectors/sqla/models.py 89.81% <0.00%> (+1.42%) ⬆️
superset/db_engine_specs/presto.py 90.31% <0.00%> (+5.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8b270d...005d6a5. Read the comment docs.

@etr2460 etr2460 merged commit 6ed0a3a into master Jun 14, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@rusackas rusackas deleted the etr2460-patch-2 branch January 30, 2023 19:21
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants