Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webpack): configure publicPath via ASSET_BASE_URL env var #15105

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

nytai
Copy link
Member

@nytai nytai commented Jun 10, 2021

SUMMARY

allows webpack publicPath to be configured via ASSET_BASE_URL env var. This should enabled static assets to be hosted on a seperate server/CDN instead of serving them via the python webserver.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

manual testing:

  • webpack build with ASSET_BASE_URL=http://localhost:9000 set, results in urls in the webpack manifest containing the prefix http://localhost:9000.
  • All asset requests in the browser load and are not to relative paths.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@nytai nytai marked this pull request as ready for review June 10, 2021 22:53
@nytai nytai merged commit 98ec365 into apache:master Jun 15, 2021
@nytai nytai deleted the tai/webpack-asset-base-url branch June 15, 2021 00:56
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants