Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(native-filters): handle descending sorting correctly #15112

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

villebro
Copy link
Member

@villebro villebro commented Jun 11, 2021

SUMMARY

Add support for descending sorting to Value Filter.

BEFORE

Setting the sort order to descending didn't affect the sort order:
image

AFTER

Now the data is correctly sorted in descending order:
image

TESTING INSTRUCTIONS

CI + new tests

ADDITIONAL INFORMATION

@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #15112 (b30857d) into master (3456dd5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15112   +/-   ##
=======================================
  Coverage   77.54%   77.54%           
=======================================
  Files         967      967           
  Lines       49759    49759           
  Branches     6352     6352           
=======================================
  Hits        38585    38585           
  Misses      10972    10972           
  Partials      202      202           
Flag Coverage Δ
javascript 72.45% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-frontend/src/filters/components/Select/types.ts 100.00% <ø> (ø)
...ontend/src/filters/components/Select/buildQuery.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3456dd5...b30857d. Read the comment docs.

@villebro villebro merged commit 5e825cf into apache:master Jun 11, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[native-filters] Sort filter values checkbox descending doesn't work
3 participants