Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): charts in nested tab is missing control and filter indicator #15134

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

stephenLYZ
Copy link
Member

@stephenLYZ stephenLYZ commented Jun 12, 2021

SUMMARY

This PR fixes the charts in nested tab is missing control and filter indicator.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

2021-06-13.12.25.32.mov

after

2021-06-13.12.27.32.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

@codecov
Copy link

codecov bot commented Jun 12, 2021

Codecov Report

Merging #15134 (ba2517d) into master (8e6a5a6) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15134   +/-   ##
=======================================
  Coverage   77.49%   77.49%           
=======================================
  Files         969      969           
  Lines       49902    49902           
  Branches     6383     6383           
=======================================
+ Hits        38671    38673    +2     
+ Misses      11029    11027    -2     
  Partials      202      202           
Flag Coverage Δ
javascript 72.38% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/src/dashboard/components/gridComponents/Tabs.jsx 88.67% <50.00%> (+1.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e6a5a6...ba2517d. Read the comment docs.

@villebro villebro requested a review from kgabryje June 16, 2021 08:49
@zhaoyongjie zhaoyongjie self-requested a review June 16, 2021 13:24
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in local, LGTM

@zhaoyongjie zhaoyongjie added need:merge The PR is ready to be merged and removed need:merge The PR is ready to be merged labels Jun 17, 2021
@rusackas rusackas merged commit e5187a4 into apache:master Jun 17, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants