Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use npm v7 in docker compose #15160

Merged
merged 1 commit into from
Jun 15, 2021
Merged

fix: use npm v7 in docker compose #15160

merged 1 commit into from
Jun 15, 2021

Conversation

suddjian
Copy link
Member

@suddjian suddjian commented Jun 15, 2021 •
edited
Loading

SUMMARY

This should get rid of the unwanted package-lock.json edits when running docker-compose.

TESTING INSTRUCTIONS

Run docker-compose?

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@pkdotson pkdotson merged commit 7b87eb1 into apache:master Jun 15, 2021
@suddjian suddjian deleted the docker-npm branch June 15, 2021 21:28
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
@suddjian
fix: use npm v7 in docker compose (apache#15160)
6b6ac05
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@suddjian
fix: use npm v7 in docker compose (apache#15160)
616e316
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@suddjian
fix: use npm v7 in docker compose (apache#15160)
b5cc380
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

@pkdotson pkdotson pkdotson approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suddjian @pkdotson @villebro @mistercrunch