chore: Migrates ControlHeader icons

[michael-s-molina]

SUMMARY

Migrates ControlHeader icons.

@pkdotson

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

1 - Go to explore
2 - Change the controls to show the icons

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #15265 (4f2d1b3) into master (2cf9946) will decrease coverage by 0.23%.
The diff coverage is 100.00%.

❗ Current head 4f2d1b3 differs from pull request most recent head 62d1ae0. Consider uploading reports for the commit 62d1ae0 to get more accurate results

@@            Coverage Diff             @@
##           master   #15265      +/-   ##
==========================================
- Coverage   77.26%   77.03%   -0.24%     
==========================================
  Files         971      972       +1     
  Lines       50308    50316       +8     
  Branches     6140     6140              
==========================================
- Hits        38869    38759     -110     
- Misses      11235    11353     +118     
  Partials      204      204              

Flag	Coverage Δ
hive	?
javascript	71.80% <100.00%> (+<0.01%)	⬆️
presto	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...-frontend/src/explore/components/ControlHeader.jsx	86.20% <100.00%> (+0.49%)	⬆️
superset/db_engine_specs/ascend.py	100.00% <100.00%> (ø)
superset/db_engines/hive.py	0.00% <0.00%> (-82.15%)	⬇️
superset/db_engine_specs/hive.py	69.20% <0.00%> (-17.21%)	⬇️
superset/db_engine_specs/presto.py	83.36% <0.00%> (-6.95%)	⬇️
superset/views/database/mixins.py	81.03% <0.00%> (-1.73%)	⬇️
superset/connectors/sqla/models.py	88.15% <0.00%> (-1.66%)	⬇️
superset/db_engine_specs/base.py	87.97% <0.00%> (-0.41%)	⬇️
superset/models/core.py	89.76% <0.00%> (-0.27%)	⬇️
superset/utils/core.py	88.93% <0.00%> (-0.13%)	⬇️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cf9946...62d1ae0. Read the comment docs.

[pkdotson]

/testenv up

[github-actions]

@pkdotson Ephemeral environment spinning up at http://54.191.171.237:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[pkdotson]

@michael-s-molina did the new icons get design signoff? I notice they are a little different but that's probably because the new icons aren't exactly the same.

[pkdotson]

LGTM!

[michael-s-molina]

I notice they are a little different but that's probably because the new icons aren't exactly the same.

@pkdotson Exactly. The new warning and error icons are different.

[rusackas]

One small detail to consider... I noticed that the icons are a little high up, vertically. It seems the anticon class has a vertical-align of -.125em for some reason. If I override that with vertical-align: middle; it aligns much better with the text.

While this sounds like a sensible global change, I'm not sure what fallout/misalignments it might cause. We can pus this PR through as is, or stop and poke around at this. Your call. If you want to merge as is, maybe we can make a project board of "Things to try when we have visual regression testing"

[michael-s-molina]

One small detail to consider... I noticed that the icons are a little high up, vertically. It seems the anticon class has a vertical-align of -.125em for some reason. If I override that with vertical-align: middle; it aligns much better with the text.

While this sounds like a sensible global change, I'm not sure what fallout/misalignments it might cause. We can pus this PR through as is, or stop and poke around at this. Your call. If you want to merge as is, maybe we can make a project board of "Things to try when we have visual regression testing"

Someone probably fixed this while changing another requirement. This is the current state with latest master:

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.