Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(add Netezza database): Add IBM Netezza support #15450

Merged
merged 5 commits into from
Jun 30, 2021
Merged

feat(add Netezza database): Add IBM Netezza support #15450

merged 5 commits into from
Jun 30, 2021

Conversation

abhishekjog
Copy link
Contributor

@abhishekjog abhishekjog commented Jun 29, 2021

SUMMARY

Add support for IBM Netezza Performance Server (aka Netezza)

TESTING INSTRUCTIONS

Install Superset
Add Database with "netezza+nzpy://user:password@host:5480/database". Test that the database is added successfully.
Create Dataset. Check that all schema and tables are listed in drop down. We have checked correct queries are fired in netezza backend logs.
Try running queries, create charts etc.

ADDITIONAL INFORMATION

  • Has associated issue: Add support for IBM Netezza #15452
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@abhishekjog abhishekjog changed the title Add netezza Add IBM Netezza support Jun 29, 2021
@abhishekjog abhishekjog changed the title Add IBM Netezza support feat (add Netezza database): Add IBM Netezza support Jun 30, 2021
@abhishekjog abhishekjog changed the title feat (add Netezza database): Add IBM Netezza support feat(add Netezza database): Add IBM Netezza support Jun 30, 2021
@abhishekjog abhishekjog marked this pull request as draft June 30, 2021 03:01
@abhishekjog abhishekjog marked this pull request as ready for review June 30, 2021 03:04
@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #15450 (2bb7c62) into master (9967a5f) will decrease coverage by 0.23%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15450      +/-   ##
==========================================
- Coverage   77.78%   77.55%   -0.24%     
==========================================
  Files         966      969       +3     
  Lines       49629    49916     +287     
  Branches     6314     6314              
==========================================
+ Hits        38606    38711     +105     
- Misses      10822    11004     +182     
  Partials      201      201              
Flag Coverage Δ
hive ?
mysql 81.66% <88.88%> (-0.05%) ⬇️
postgres 81.67% <88.88%> (-0.06%) ⬇️
presto ?
python 81.76% <88.88%> (-0.50%) ⬇️
sqlite 81.30% <88.88%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/netezza.py 88.88% <88.88%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/trino.py 59.72% <0.00%> (-35.02%) ⬇️
superset/app.py 63.49% <0.00%> (-24.19%) ⬇️
superset/db_engine_specs/hive.py 69.20% <0.00%> (-18.20%) ⬇️
superset/exceptions.py 90.47% <0.00%> (-8.23%) ⬇️
superset/db_engine_specs/presto.py 83.36% <0.00%> (-6.95%) ⬇️
superset/databases/commands/create.py 88.23% <0.00%> (-3.93%) ⬇️
superset/connectors/connector_registry.py 83.33% <0.00%> (-2.95%) ⬇️
superset/dashboards/commands/importers/v0.py 89.94% <0.00%> (-2.92%) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9967a5f...2bb7c62. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Please fix the linting error, after that I think this is good to go.

superset/db_engine_specs/netezza.py Outdated Show resolved Hide resolved
@srinify srinify merged commit 7ad8fd5 into apache:master Jun 30, 2021
@john-bodley
Copy link
Member

john-bodley commented Jun 30, 2021

@abhishekjog could you also add/update the documentation?

@abhishekjog
Copy link
Contributor Author

@abhishekjog could you also add/update the documentation?

yes. I had raised a separate PR, which is now merged.

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* Add netezza to superset

* update netezza logo

* change in logo filename

* fixing linter error

* removing stray code
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* Add netezza to superset

* update netezza logo

* change in logo filename

* fixing linter error

* removing stray code
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* Add netezza to superset

* update netezza logo

* change in logo filename

* fixing linter error

* removing stray code
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants