Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: indentation in helm chart #15547

Merged
merged 2 commits into from
Jul 6, 2021
Merged

fix: indentation in helm chart #15547

merged 2 commits into from
Jul 6, 2021

Conversation

mvoitko
Copy link
Contributor

@mvoitko mvoitko commented Jul 5, 2021

SUMMARY

Fix indentation in helm chart

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@mvoitko mvoitko force-pushed the fix/indentation-in-Helm-chart branch from 6c64ee3 to 12c22c2 Compare July 5, 2021 21:04
@mvoitko
Copy link
Contributor Author

mvoitko commented Jul 5, 2021

@craig-rueda could you please review?

@craig-rueda craig-rueda merged commit 08bda27 into apache:master Jul 6, 2021
@mvoitko mvoitko deleted the fix/indentation-in-Helm-chart branch July 25, 2021 21:02
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
@mvoitko
fix: indentation in Helm chart (apache#15547)
4363017
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@mvoitko
fix: indentation in Helm chart (apache#15547)
fd8e203
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mvoitko
fix: indentation in Helm chart (apache#15547)
1ccf6c5
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craig-rueda craig-rueda craig-rueda approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvoitko @craig-rueda @mistercrunch