Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enhance Select component #15550

Merged
merged 1 commit into from
Jul 6, 2021
Merged

chore: Enhance Select component #15550

merged 1 commit into from
Jul 6, 2021

Conversation

geido
Copy link
Member

@geido geido commented Jul 6, 2021

SUMMARY

Improves the Select component UI/UX.

  • Fixes some bugs of the Select component related to searching and selection
  • Simplifies the Select API for the async non-paginated version

All the kudos for these latest changes go to @michael-s-molina. I am opening up this PR on his behalf to make async work easier.

TESTING INSTRUCTIONS

Testing is only possible in an isolated state with Storybook.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #15550 (c82c676) into master (0af5a3d) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15550      +/-   ##
==========================================
+ Coverage   76.93%   76.95%   +0.01%     
==========================================
  Files         976      976              
  Lines       51320    51311       -9     
  Branches     6912     6907       -5     
==========================================
  Hits        39485    39485              
+ Misses      11616    11607       -9     
  Partials      219      219              
Flag Coverage Δ
javascript 71.41% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Select/Select.tsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0af5a3d...c82c676. Read the comment docs.

@michael-s-molina michael-s-molina merged commit 314d49c into apache:master Jul 6, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants