-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: icon to icons for filterbadge components #15557
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15557 +/- ##
==========================================
- Coverage 76.93% 76.87% -0.07%
==========================================
Files 976 976
Lines 51320 51310 -10
Branches 6912 6907 -5
==========================================
- Hits 39485 39445 -40
- Misses 11616 11646 +30
Partials 219 219
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@michael-s-molina Ephemeral environment spinning up at http://52.39.157.201:8080. Credentials are |
That didn't work out... I'll try again |
@rusackas Ephemeral environment spinning up at http://34.218.229.199:8080. Credentials are |
1 similar comment
@rusackas Ephemeral environment spinning up at http://34.218.229.199:8080. Credentials are |
/testenv up FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_DASHBOARD_NATIVE_FILTERS=true |
@rusackas Ephemeral environment spinning up at http://54.200.214.107:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ephemeral environment shutdown and build artifacts deleted. |
* initial commit * fix test
* initial commit * fix test
* initial commit * fix test
SUMMARY
This pr migrates the original icon to icons for filterbadge components. Specifically the crossfilter filter icon
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
To test you must enable native filters and cross filtering.
ADDITIONAL INFORMATION