Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: icon to icons for filterbadge components #15557

Merged
merged 2 commits into from
Jul 8, 2021

Conversation

pkdotson
Copy link
Member

@pkdotson pkdotson commented Jul 6, 2021

SUMMARY

This pr migrates the original icon to icons for filterbadge components. Specifically the crossfilter filter icon

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2021-07-06 at 12 32 45 PM

TESTING INSTRUCTIONS

To test you must enable native filters and cross filtering.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #15557 (e5fe58f) into master (0af5a3d) will decrease coverage by 0.06%.
The diff coverage is 3.70%.

❗ Current head e5fe58f differs from pull request most recent head 04ace97. Consider uploading reports for the commit 04ace97 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15557      +/-   ##
==========================================
- Coverage   76.93%   76.87%   -0.07%     
==========================================
  Files         976      976              
  Lines       51320    51310      -10     
  Branches     6912     6907       -5     
==========================================
- Hits        39485    39445      -40     
- Misses      11616    11646      +30     
  Partials      219      219              
Flag Coverage Δ
javascript 71.41% <3.70%> (+0.02%) ⬆️
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Select/Select.tsx 0.00% <0.00%> (ø)
...d/src/dashboard/components/FiltersBadge/Styles.tsx 94.87% <ø> (ø)
...nd/src/dashboard/components/FiltersBadge/index.tsx 86.74% <ø> (-0.16%) ⬇️
...ard/components/FiltersBadge/DetailsPanel/index.tsx 87.30% <100.00%> (ø)
superset/db_engine_specs/presto.py 84.42% <0.00%> (-5.48%) ⬇️
superset/connectors/sqla/models.py 88.49% <0.00%> (-1.41%) ⬇️
superset/models/core.py 89.76% <0.00%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0af5a3d...04ace97. Read the comment docs.

@michael-s-molina
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2021

@michael-s-molina Ephemeral environment spinning up at http://52.39.157.201:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@rusackas
Copy link
Member

rusackas commented Jul 7, 2021

/testenv up FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_DASHBOARD_NATIVE_FILTERS=true

That didn't work out... I'll try again

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2021

@rusackas Ephemeral environment spinning up at http://34.218.229.199:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2021

@rusackas Ephemeral environment spinning up at http://34.218.229.199:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@rusackas
Copy link
Member

rusackas commented Jul 7, 2021

/testenv up FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_DASHBOARD_NATIVE_FILTERS=true

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2021

@rusackas Ephemeral environment spinning up at http://54.200.214.107:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaoyongjie zhaoyongjie merged commit abd999b into apache:master Jul 8, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2021

Ephemeral environment shutdown and build artifacts deleted.

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants