Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: icon to icons for homepage and card compompents #15624

Merged
merged 3 commits into from
Jul 12, 2021
Merged

refactor: icon to icons for homepage and card compompents #15624

merged 3 commits into from
Jul 12, 2021

Conversation

pkdotson
Copy link
Member

@pkdotson pkdotson commented Jul 9, 2021

SUMMARY

This pr migrates the old icon to icons components for the chart card and home page card components.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2021-07-09 at 2 45 39 PM

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 9, 2021 •
edited
Loading

Codecov Report

Merging #15624 (97d9c1e) into master (ee8b1ed) will decrease coverage by 0.01%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15624      +/-   ##
==========================================
- Coverage   76.95%   76.94%   -0.02%     
==========================================
  Files         976      976              
  Lines       51328    51338      +10     
  Branches     6910     6919       +9     
==========================================
+ Hits        39498    39500       +2     
- Misses      11611    11615       +4     
- Partials      219      223       +4
Flag Coverage Δ
javascript 71.39% <92.85%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-frontend/src/views/CRUD/welcome/ActivityTable.tsx 78.84% <85.71%> (+0.41%) ⬆️
...set-frontend/src/components/ListViewCard/index.tsx 100.00% <100.00%> (ø)
...perset-frontend/src/views/CRUD/chart/ChartCard.tsx 75.60% <100.00%> (ø)
...t-frontend/src/views/CRUD/welcome/SavedQueries.tsx 61.00% <100.00%> (+0.39%) ⬆️
superset-frontend/src/filters/components/common.ts 90.00% <0.00%> (-10.00%) ⬇️
...d/src/filters/components/Time/TimeFilterPlugin.tsx 86.66% <0.00%> (-5.65%) ⬇️
...s/CRUD/data/database/DatabaseModal/ModalHeader.tsx 89.18% <0.00%> (-2.48%) ⬇️
...ters/FiltersConfigModal/FiltersConfigForm/state.ts 88.88% <0.00%> (-2.03%) ⬇️
...src/filters/components/Range/RangeFilterPlugin.tsx 89.18% <0.00%> (-1.59%) ⬇️
...c/filters/components/Select/SelectFilterPlugin.tsx 79.82% <0.00%> (-0.88%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee8b1ed...97d9c1e. Read the comment docs.

michael-s-molina
michael-s-molina approved these changes Jul 10, 2021
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with @suddjian suggestion.

geido
geido approved these changes Jul 12, 2021
View reviewed changes
Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pkdotson pkdotson merged commit 79d3d06 into apache:master Jul 12, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
@pkdotson
refactor: icon to icons for homepage and card compompents (apache#15624)
6ccb7ee 
* initial commit

* add listviewcard

* remove plural
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@pkdotson
refactor: icon to icons for homepage and card compompents (apache#15624)
d3a8bc6 
* initial commit

* add listviewcard

* remove plural
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@pkdotson
refactor: icon to icons for homepage and card compompents (apache#15624)
a96ecdc 
* initial commit

* add listviewcard

* remove plural
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suddjian suddjian suddjian left review comments

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@geido geido geido approved these changes

@rusackas rusackas Awaiting requested review from rusackas

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pkdotson @suddjian @geido @michael-s-molina @mistercrunch