Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(explore): Bump plugin-chart-pivot-table #15742

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

kgabryje
Copy link
Member

SUMMARY

Bumps @superset-ui/plugin-chart-pivot-table to version 0.17.68. This change will introduce conditional formatting, d3 formatting of metrics from dataset, date formatting, combining metrics and new expand/collapse icons for pivot table. For details, see apache-superset/superset-ui#1217

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

See videos in apache-superset/superset-ui#1217

TESTING INSTRUCTIONS

Conditional formatting: test behaviour described in #15651

D3 formatting for metrics:

  1. Open Edit Dataset modal and set custom formatting for some saved metrics
  2. Create a pivot table with those metrics
  3. Verify that formatting from dataset has been applied
  4. Verify that formatting from dataset overrides formatting defined in Customize tab

Date formatting:

  1. Create a pivot table, use temporal columns as row or column groups
  2. Verify that date formatting selected in Customize tab is applied correctly

Combining metrics:

  1. Create a pivot table and check "Combine metrics" checkbox
  2. Verify that now metrics are used as the lowest level group rather than highest
  3. Verify that the feature works with Transpose pivot and applying metrics to rows instead of columns

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

CC @junlincc

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #15742 (88dcfa0) into master (fe68e45) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15742   +/-   ##
=======================================
  Coverage   76.91%   76.91%           
=======================================
  Files         983      983           
  Lines       51609    51609           
  Branches     6988     6988           
=======================================
  Hits        39696    39696           
  Misses      11690    11690           
  Partials      223      223           
Flag Coverage Δ
javascript 71.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe68e45...88dcfa0. Read the comment docs.

@kgabryje kgabryje merged commit e9383e6 into apache:master Jul 16, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants