-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migration to add timezone to report schedule #15747
feat: migration to add timezone to report schedule #15747
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15747 +/- ##
==========================================
- Coverage 77.13% 76.90% -0.23%
==========================================
Files 984 984
Lines 51677 51677
Branches 6995 6995
==========================================
- Hits 39860 39742 -118
- Misses 11593 11711 +118
Partials 224 224
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
superset/migrations/versions/ae1ed299413b_add_timezone_to_report_schedule.py
Outdated
Show resolved
Hide resolved
superset/migrations/versions/ae1ed299413b_add_timezone_to_report_schedule.py
Outdated
Show resolved
Hide resolved
thanks @betodealmeida |
The failing test is at |
❗ Please consider rebasing your branch to avoid db migration conflicts. |
c1f4d06
to
baf4c11
Compare
❗ Please consider rebasing your branch to avoid db migration conflicts. |
baf4c11
to
4165cf4
Compare
❗ Please consider rebasing your branch to avoid db migration conflicts. |
1 similar comment
❗ Please consider rebasing your branch to avoid db migration conflicts. |
0b1057e
to
9ecd2ac
Compare
9ecd2ac
to
f081ddd
Compare
SUMMARY
Adds timezone to report schedule db in order to allow us to add a UI on the reports for users to select a timezone for their schedule. Timezones are strings of locations, such as "America/Los_Angeles" or "UTC".
The default value of UTC as an example will be GMT, which is the current +0 offset time that we are using.
In the future UI, the plan is to "guess" the user's timezone and default the selection to their current timezone.
For context, the full PR is https://github.com/apache/superset/pull/15743/files
TESTING INSTRUCTIONS
results of db migration script:
Current: 0.33 s
10+: 0.34 s
100+: 0.32 s
1000+: 0.33 s
ADDITIONAL INFORMATION