-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Revert "quote column name if db requires (#15465)" #15752
Conversation
This reverts commit 80b8df0.
Codecov Report
@@ Coverage Diff @@
## master #15752 +/- ##
==========================================
- Coverage 76.92% 76.69% -0.23%
==========================================
Files 983 983
Lines 51609 51607 -2
Branches 6988 6988
==========================================
- Hits 39698 39578 -120
- Misses 11688 11806 +118
Partials 223 223
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
🏷 2021.27 |
This reverts commit 80b8df0.
This reverts commit 80b8df0.
This reverts commit 4986f97.
This reverts commit 80b8df0.
SUMMARY
The commit above fixes cases for virtual datasets where an alias for a column was created with quotes for snowflake, but it does not work for regular datasets where the columns have not been aliased. Reverting this change for now because it is less likely to have a chart that relies on a dataset with a named, quoted aliases, than it it to be using an unquoted alias or a table.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
NA
TESTING INSTRUCTIONS
create a dataset or virtual dataset and try to create a chart from it
ADDITIONAL INFORMATION