Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "quote column name if db requires (#15465)" #15752

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

eschutho
Copy link
Member

This reverts commit 80b8df0.

SUMMARY

The commit above fixes cases for virtual datasets where an alias for a column was created with quotes for snowflake, but it does not work for regular datasets where the columns have not been aliased. Reverting this change for now because it is less likely to have a chart that relies on a dataset with a named, quoted aliases, than it it to be using an unquoted alias or a table.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

NA

TESTING INSTRUCTIONS

create a dataset or virtual dataset and try to create a chart from it

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 17, 2021

Codecov Report

Merging #15752 (83c48fc) into master (e9383e6) will decrease coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15752      +/-   ##
==========================================
- Coverage   76.92%   76.69%   -0.23%     
==========================================
  Files         983      983              
  Lines       51609    51607       -2     
  Branches     6988     6988              
==========================================
- Hits        39698    39578     -120     
- Misses      11688    11806     +118     
  Partials      223      223              
Flag Coverage Δ
hive ?
mysql 81.54% <100.00%> (-0.01%) ⬇️
postgres 81.56% <100.00%> (-0.01%) ⬇️
presto ?
python 81.65% <100.00%> (-0.45%) ⬇️
sqlite 81.18% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/connectors/sqla/models.py 88.23% <100.00%> (-1.68%) ⬇️
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 69.44% <0.00%> (-17.07%) ⬇️
superset/db_engine_specs/presto.py 83.36% <0.00%> (-6.95%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/db_engine_specs/base.py 88.28% <0.00%> (-0.40%) ⬇️
superset/models/core.py 89.79% <0.00%> (-0.27%) ⬇️
superset/utils/core.py 88.12% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9383e6...83c48fc. Read the comment docs.

@eschutho eschutho changed the title Revert "quote column name if db requires (#15465)" fix: Revert "quote column name if db requires (#15465)" Jul 19, 2021
@rosemarie-chiu
Copy link
Contributor

🏷 2021.27

@eschutho eschutho merged commit 618a354 into apache:master Jul 19, 2021
@eschutho eschutho deleted the elizabeth/fix-snowflake branch July 19, 2021 17:31
henryyeh pushed a commit to preset-io/superset that referenced this pull request Jul 19, 2021
@rosemarie-chiu
Copy link
Contributor

Verified by QA.

Before:
image

After:
image

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants