Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect translations in Chinese in messages.po #15813

Merged
merged 1 commit into from
Jul 26, 2021
Merged

fix: Incorrect translations in Chinese in messages.po #15813

merged 1 commit into from
Jul 26, 2021

Conversation

chuancyzhang
Copy link
Contributor

SUMMARY

Chinese translation and English translation do not match,"CREATE VIEW AS" should correspond to "CREATE VIEW AS", not "CREATE TABLE AS"

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #15813 (1b619eb) into master (6cb91ee) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15813      +/-   ##
==========================================
+ Coverage   77.05%   77.13%   +0.07%     
==========================================
  Files         984      984              
  Lines       51650    51650              
  Branches     6991     6991              
==========================================
+ Hits        39801    39840      +39     
+ Misses      11625    11586      -39     
  Partials      224      224              
Flag Coverage Δ
hive 81.29% <ø> (ø)
mysql 81.55% <ø> (-0.01%) ⬇️
postgres 81.57% <ø> (ø)
presto 81.28% <ø> (?)
python 82.10% <ø> (+0.14%) ⬆️
sqlite 81.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/models/core.py 89.87% <0.00%> (+0.25%) ⬆️
superset/connectors/sqla/models.py 89.88% <0.00%> (+1.41%) ⬆️
superset/db_engine_specs/presto.py 89.89% <0.00%> (+5.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cb91ee...1b619eb. Read the comment docs.

@junlincc junlincc requested a review from ktmud July 21, 2021 21:39
@rusackas rusackas merged commit 2d00565 into apache:master Jul 26, 2021
@chuancyzhang chuancyzhang deleted the patch-9 branch July 27, 2021 02:55
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants