feat: add timezones to report cron #15849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eschutho
force-pushed
the
elizabeth/add_timezone_to_cron
branch
2 times, most recently
from
d74a7fd
to
bd17a85
Compare
eschutho
force-pushed
the
elizabeth/add_timezone_to_cron
branch
from
bd17a85
to
60662ec
Compare
eschutho
force-pushed
the
elizabeth/add_timezone_to_cron
branch
from
60662ec
to
e8deda7
Compare
eschutho
force-pushed
the
elizabeth/add_timezone_to_cron
branch
from
e8deda7
to
b086d52
Compare
hughhhh
reviewed
Jul 27, 2021
| rv = self.client.post(uri, json=report_schedule_data) | ||
| assert rv.status_code == 400 | ||
| data = json.loads(rv.data.decode("utf-8")) | ||
| assert data == {"message": {"timezone": ["Field may not be null."]}} |
There was a problem hiding this comment.
nit: write this as a separate test
There was a problem hiding this comment.
do you think because it's a negative assertion instead of the positive ones?
hughhhh
approved these changes
Jul 27, 2021
Codecov Report
@@ Coverage Diff @@
## master #15849 +/- ##
==========================================
- Coverage 77.09% 76.81% -0.29%
==========================================
Files 984 986 +2
Lines 51782 51872 +90
Branches 7028 7028
==========================================
- Hits 39920 39843 -77
- Misses 11637 11804 +167
Partials 225 225
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
* add timezones to report cron * fix test
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
* add timezones to report cron * fix test
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
* add timezones to report cron * fix test
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* add timezones to report cron * fix test
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
We have a new column on the report_schedule table that defaults timezone to "UTC". This pr reads that timezone from the report and then runs the cron schedule according to that schedule. In a future PR I will add in a UI that allows users to change that timezone and save different values to the report_schedule table, such as "America/New_York" or "America/Los_Angeles"
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
We want to make sure that all existing reports continue to run on UTC. To test, create a report and make sure that it runs at the appropriate time.
This ran at 4:44pm PDT
ADDITIONAL INFORMATION