Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create/onsave Email Report functionality for Dashboard and Chart #15856

Merged
merged 30 commits into from
Jul 28, 2021
Merged

feat: Create/onsave Email Report functionality for Dashboard and Chart #15856

merged 30 commits into from
Jul 28, 2021

Commits on Jul 19, 2021

  1. style: Rough draft of email report modal (apache#15666) 

    * clears errors when closing out of modal (apache#15623)

* add test + fix types

* fix lint errors

* Building ReportModal component

* Continued ReportModal creation

* Visual details updated

* CronError style

* Very basic testing added

Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
    @lyndsiWilliams @AAfghahi @eschutho
    2 people authored and eschutho committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    0e3088a View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2021

  1. feat: toggle the ReportModal Icon based on user permissions (apache#1… 

    …5780)

* style: Rough draft of email report modal (apache#15666)

* clears errors when closing out of modal (apache#15623)

* fix: avoid fetching favorite status for anonymous user (apache#15590)

* avoid fetching favorite status for anonymous user

* add test + fix types

* fix lint errors

* Building ReportModal component

* Continued ReportModal creation

* Visual details updated

* CronError style

* Very basic testing added

Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
Co-authored-by: aspedrosa <aspedrosa@ua.pt>

* first draft

* added testing props

* cleaned up rebase

* changed name and type

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: aspedrosa <aspedrosa@ua.pt>
    @AAfghahi @lyndsiWilliams
    3 people committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    03f8ddd View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2021

  1. feat: Begin incorporation of email report modal to Charts (apache#15793) 

    * Add email report modal to Charts

* Fix px themes
    @lyndsiWilliams
    lyndsiWilliams committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    6a79189 View commit details
    Browse the repository at this point in the history

  2. feat: fetch UI specific reports (apache#15785) 

    * style: Rough draft of email report modal (apache#15666)

* clears errors when closing out of modal (apache#15623)

* fix: avoid fetching favorite status for anonymous user (apache#15590)

* avoid fetching favorite status for anonymous user

* add test + fix types

* fix lint errors

* Building ReportModal component

* Continued ReportModal creation

* Visual details updated

* CronError style

* Very basic testing added

Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
Co-authored-by: aspedrosa <aspedrosa@ua.pt>

* first draft

* created Api call

* added click logic

* made the fetch report into a action/reducer

* abstracted report action

* revision

* added reportState to reducer

* reports conditions

* revisions

* revisions

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: aspedrosa <aspedrosa@ua.pt>
    @AAfghahi @lyndsiWilliams
    3 people committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    900a244 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2021

  1. fix: Edit physical dataset from the Edit Dataset modal (apache#15770) 

    * Remove unnecessary onChange

* Remove confliciting onChange

* Revert unnecessary change

* Enhance and fix tests
    @geido @lyndsiWilliams
    geido authored and lyndsiWilliams committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    c8d5dba View commit details
    Browse the repository at this point in the history

  2. feat: add show columns to Reports model (apache#15712) 

    * added logic for creation_method

* revisions

* added index

* Update superset/migrations/versions/3317e9248280_add_creation_method_to_reports_model.py

* filters

* search columns updated
    @AAfghahi @lyndsiWilliams
    AAfghahi authored and lyndsiWilliams committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    1561372 View commit details
    Browse the repository at this point in the history

  3. fix: margin right on warning icon to 8px (apache#15715) 

    * changed margin right on warning icon to 8px

* fixed to grid units from pixels
    @stellalc7 @lyndsiWilliams
    stellalc7 authored and lyndsiWilliams committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    74e120d View commit details
    Browse the repository at this point in the history

  4. feat: adding Progress Bar to Benchmark script (apache#15719) 

    * rough draft of benchmark script

* revisions

* revisions

* rough draft of benchmark script

* revisions

* Update requirements/development.in

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset/utils/mock_data.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* more revisions

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
    @AAfghahi @betodealmeida @lyndsiWilliams
    2 people authored and lyndsiWilliams committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    961fcf0 View commit details
    Browse the repository at this point in the history

  5. fix: migration downgrade references wrong column (apache#15791)

    @betodealmeida @lyndsiWilliams
    betodealmeida authored and lyndsiWilliams committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    5c44960 View commit details
    Browse the repository at this point in the history

  6. fix(dashboard): Add resize handles to right and bottom of component (a… 

    …pache#15778)

* fix(dashboard): Add resize handles to right and bottom of component

* Fix test
    @kgabryje @lyndsiWilliams
    kgabryje authored and lyndsiWilliams committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    abb464a View commit details
    Browse the repository at this point in the history

  7. chore: Add tags to the new viz gallery (apache#15734) 

    * chore: add tags to gallery

* fix UT

* fix lint

* redesign tags filter

* chore: change to Highly-used and fix some css

* fix UT

Co-authored-by: stephenLYZ <750188453@qq.com>
    @zhaoyongjie @stephenLYZ @lyndsiWilliams
    2 people authored and lyndsiWilliams committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    1a0803e View commit details
    Browse the repository at this point in the history

  8. chore: bump 0.17.70 (apache#15795)

    @zhaoyongjie @lyndsiWilliams
    zhaoyongjie authored and lyndsiWilliams committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    67edec6 View commit details
    Browse the repository at this point in the history

  9. docs: Adding Sunbird to users list (apache#15794)

    @kumarks1122 @lyndsiWilliams
    kumarks1122 authored and lyndsiWilliams committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    98e8f06 View commit details
    Browse the repository at this point in the history

  10. chore: Improves the Select component UI/UX - iteration 4 (apache#15480)

    @michael-s-molina @lyndsiWilliams
    michael-s-molina authored and lyndsiWilliams committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    f1bac8b View commit details
    Browse the repository at this point in the history

  11. Add z-index only on maximize (apache#15800)

    @geido @lyndsiWilliams
    geido authored and lyndsiWilliams committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    797efdd View commit details
    Browse the repository at this point in the history

  12. chore: remove retry dependency in favor of backoff (apache#15788) 

    * chore: remove retry dep in favor of backoff

* Fix lint
    @betodealmeida @lyndsiWilliams
    betodealmeida authored and lyndsiWilliams committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    a24fcdb View commit details
    Browse the repository at this point in the history

  13. fix: create fk model in benchmark script (apache#15804)

    @betodealmeida @lyndsiWilliams
    betodealmeida authored and lyndsiWilliams committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    425815e View commit details
    Browse the repository at this point in the history

  14. style: Rough draft of email report modal (apache#15666) 

    * clears errors when closing out of modal (apache#15623)

* fix: avoid fetching favorite status for anonymous user (apache#15590)

* avoid fetching favorite status for anonymous user

* add test + fix types

* fix lint errors

* Building ReportModal component

* Continued ReportModal creation

* Visual details updated

* CronError style

* Very basic testing added

Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
Co-authored-by: aspedrosa <aspedrosa@ua.pt>
    @lyndsiWilliams @AAfghahi
    3 people committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    1641250 View commit details
    Browse the repository at this point in the history

  15. Working on onSave functionality

    @lyndsiWilliams
    lyndsiWilliams committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    7d4ffbd View commit details
    Browse the repository at this point in the history

  16. style: Rough draft of email report modal (apache#15666) 

    * clears errors when closing out of modal (apache#15623)

* add test + fix types

* fix lint errors

* Building ReportModal component

* Continued ReportModal creation

* Visual details updated

* CronError style

* Very basic testing added

Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
    @lyndsiWilliams @AAfghahi
    lyndsiWilliams and AAfghahi committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    82045aa View commit details
    Browse the repository at this point in the history

  17. feat: toggle the ReportModal Icon based on user permissions (apache#1… 

    …5780)

* style: Rough draft of email report modal (apache#15666)

* clears errors when closing out of modal (apache#15623)

* fix: avoid fetching favorite status for anonymous user (apache#15590)

* avoid fetching favorite status for anonymous user

* add test + fix types

* fix lint errors

* Building ReportModal component

* Continued ReportModal creation

* Visual details updated

* CronError style

* Very basic testing added

Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
Co-authored-by: aspedrosa <aspedrosa@ua.pt>

* first draft

* added testing props

* cleaned up rebase

* changed name and type

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: aspedrosa <aspedrosa@ua.pt>
    @AAfghahi @lyndsiWilliams
    3 people committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    1739db1 View commit details
    Browse the repository at this point in the history

  18. feat: fetch UI specific reports (apache#15785) 

    * style: Rough draft of email report modal (apache#15666)

* clears errors when closing out of modal (apache#15623)

* fix: avoid fetching favorite status for anonymous user (apache#15590)

* avoid fetching favorite status for anonymous user

* add test + fix types

* fix lint errors

* Building ReportModal component

* Continued ReportModal creation

* Visual details updated

* CronError style

* Very basic testing added

Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
Co-authored-by: aspedrosa <aspedrosa@ua.pt>

* first draft

* created Api call

* added click logic

* made the fetch report into a action/reducer

* abstracted report action

* revision

* added reportState to reducer

* reports conditions

* revisions

* revisions

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: aspedrosa <aspedrosa@ua.pt>
    @AAfghahi @lyndsiWilliams
    3 people committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    dc2482c View commit details
    Browse the repository at this point in the history

  19. Dashboard onSave progress

    @lyndsiWilliams
    lyndsiWilliams committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    9b43572 View commit details
    Browse the repository at this point in the history

  20. More onSave/create progress

    @lyndsiWilliams
    lyndsiWilliams committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    d325e8e View commit details
    Browse the repository at this point in the history

  21. Dashboard POST working!

    @lyndsiWilliams
    lyndsiWilliams committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    df6acae View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2021

  1. Dashboard POST relocated to redux

    @lyndsiWilliams
    lyndsiWilliams committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    da51d03 View commit details
    Browse the repository at this point in the history

  2. POST now also working in Charts

    @lyndsiWilliams
    lyndsiWilliams committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    2d0ed0b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'selfSubscribeReports' of https://github.com/apache/supe… 

    …rset into lyndsi/onsave
    @lyndsiWilliams
    lyndsiWilliams committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    4a757b4 View commit details
    Browse the repository at this point in the history

  4. making linter happy

    @lyndsiWilliams
    lyndsiWilliams committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    9bc1065 View commit details
    Browse the repository at this point in the history

  5. linter again

    @lyndsiWilliams
    lyndsiWilliams committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    3892059 View commit details
    Browse the repository at this point in the history