Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Charts sort by in edit mode gets cut off #15896

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes #14799

@junlincc @jinghua-qa

AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2021-07-26.at.9.14.05.AM.mov

TESTING INSTRUCTIONS

See the original issue for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #15896 (294fa12) into master (9c81599) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15896      +/-   ##
==========================================
- Coverage   77.08%   77.08%   -0.01%     
==========================================
  Files         984      984              
  Lines       51788    51787       -1     
  Branches     7037     7037              
==========================================
- Hits        39923    39922       -1     
  Misses      11640    11640              
  Partials      225      225              
Flag Coverage Δ
javascript 71.73% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Select/Select.tsx 73.05% <ø> (ø)
...t-frontend/src/dashboard/components/SliceAdder.jsx 77.02% <100.00%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c81599...294fa12. Read the comment docs.

@junlincc
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@junlincc Ephemeral environment spinning up at http://52.24.191.183:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@junlincc
Copy link
Member

LGTM!
Screen Shot 2021-07-26 at 12 34 27 PM

Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTG! Thanks for changing to the new select component!

@michael-s-molina michael-s-molina merged commit 5be0a89 into apache:master Jul 26, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dashboard]Charts Sort-by in Edit mode get cut off
4 participants