Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add timezone selector to report modal #15922

Conversation

eschutho
Copy link
Member

SUMMARY

This PR adds the timezone selector to the reports modal

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

_DEV__snowflake

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho eschutho changed the title add timezone selector to report modal feat: add timezone selector to report modal Jul 28, 2021
@eschutho eschutho force-pushed the elizabeth/add_timezone_to_report_from_dashboard_chart branch from d43113d to fadc7ac Compare July 28, 2021 17:01
@eschutho eschutho closed this Jul 28, 2021
@eschutho eschutho reopened this Jul 28, 2021
@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #15922 (5c8f530) into selfSubscribeReports (a6687d3) will increase coverage by 0.23%.
The diff coverage is 100.00%.

❗ Current head 5c8f530 differs from pull request most recent head b714fd6. Consider uploading reports for the commit b714fd6 to get more accurate results
Impacted file tree graph

@@                   Coverage Diff                    @@
##           selfSubscribeReports   #15922      +/-   ##
========================================================
+ Coverage                 76.58%   76.82%   +0.23%     
========================================================
  Files                       989      989              
  Lines                     51977    52023      +46     
  Branches                   7102     7103       +1     
========================================================
+ Hits                      39809    39969     +160     
+ Misses                    11943    11829     -114     
  Partials                    225      225              
Flag Coverage Δ
javascript 71.70% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/components/Form/LabeledErrorBoundInput.tsx 100.00% <100.00%> (ø)
...rset-frontend/src/components/ReportModal/index.tsx 94.73% <100.00%> (+0.61%) ⬆️
superset/connectors/sqla/views.py 64.01% <0.00%> (-0.31%) ⬇️
superset/errors.py 100.00% <0.00%> (ø)
superset/reports/notifications/email.py 100.00% <0.00%> (ø)
superset/sql_parse.py 99.38% <0.00%> (+<0.01%) ⬆️
superset/connectors/sqla/models.py 88.31% <0.00%> (+0.01%) ⬆️
superset/initialization/__init__.py 87.91% <0.00%> (+0.08%) ⬆️
superset/migrations/shared/security_converge.py 86.92% <0.00%> (+0.10%) ⬆️
superset/utils/log.py 93.10% <0.00%> (+0.14%) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6687d3...b714fd6. Read the comment docs.

@pull-request-size pull-request-size bot added size/S and removed size/M labels Jul 28, 2021
@eschutho eschutho merged commit e145deb into apache:selfSubscribeReports Jul 28, 2021
@eschutho eschutho deleted the elizabeth/add_timezone_to_report_from_dashboard_chart branch July 28, 2021 23:42
eschutho added a commit that referenced this pull request Jul 30, 2021
@eschutho
Copy link
Member Author

This fixes a portion of #13954

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants