fix(explore): dnd error when dragging metric if multi: false

[kgabryje]

SUMMARY

When dragging a metric a bit in a control that accepts only a single metric, an error occurred. After this fix not only there's no error, but also "Run" button doesn't highlight (as there's no actual change).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: see linked issue
After:
https://user-images.githubusercontent.com/15073128/128349174-53832874-e7d7-42ea-8080-13020bd995fd.mov

TESTING INSTRUCTIONS

0. Enable dnd
1. Open a chart that accepts only 1 metric (e.g. Big Number)
2. Add a metric
3. Drag the metric label a bit
4. There should be no "Run" button highlighted and after user clicks run, there's no error

ADDITIONAL INFORMATION

• Has associated issue: fixes [d&d][big number with trend line] Move Metric from 'METRIC' filed will lead to unexpected error #16083
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

CC @junlincc @jinghua-qa

[codecov]

Codecov Report

Merging #16088 (1657e69) into master (a59d458) will decrease coverage by 0.03%.
The diff coverage is 66.66%.

❗ Current head 1657e69 differs from pull request most recent head af164b3. Consider uploading reports for the commit af164b3 to get more accurate results

@@            Coverage Diff             @@
##           master   #16088      +/-   ##
==========================================
- Coverage   76.86%   76.83%   -0.04%     
==========================================
  Files         995      995              
  Lines       52876    52890      +14     
  Branches     6720     6724       +4     
==========================================
- Hits        40645    40639       -6     
- Misses      12005    12026      +21     
+ Partials      226      225       -1     

Flag	Coverage Δ
javascript	71.22% <75.00%> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset-frontend/src/dashboard/actions/hydrate.js	1.69% <0.00%> (-0.02%)	⬇️
...tend/src/explore/components/ExploreChartHeader.jsx	55.55% <0.00%> (-0.79%)	⬇️
...nents/controls/MetricControl/AdhocMetricOption.jsx	75.00% <ø> (ø)
...s/controls/MetricControl/MetricDefinitionValue.jsx	80.00% <ø> (ø)
...mponents/controls/MetricControl/MetricsControl.jsx	82.94% <ø> (ø)
superset/charts/schemas.py	100.00% <ø> (ø)
superset/cli.py	51.34% <0.00%> (-0.13%)	⬇️
superset/constants.py	100.00% <ø> (ø)
superset/dashboards/schemas.py	99.37% <ø> (-0.01%)	⬇️
superset/examples/random_time_series.py	19.44% <ø> (ø)
... and 16 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a59d458...af164b3. Read the comment docs.

[kgabryje]

/testenv up FEATURE_ENABLE_DRAG_AND_DROP=true

[geido]

The code looks good to me. Now waiting for env to spin up for manual testing

[github-actions]

@kgabryje Container image not yet published for this PR. Please try again when build is complete.

[github-actions]

@kgabryje Ephemeral environment creation failed. Please check the Actions logs for details.

[kgabryje]

/testenv up FEATURE_ENABLE_DRAG_AND_DROP=true

[github-actions]

@kgabryje Ephemeral environment spinning up at http://52.42.154.69:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[michael-s-molina]

I was able to reproduce the error:

Screen.Recording.2021-08-06.at.8.57.31.AM.mov

[kgabryje]

@michael-s-molina Thanks for catching that! My original fix worked with dnd enabled, I added a fix for non-dnd now

Screen.Recording.2021-08-09.at.10.47.40.mov

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.

[rosemarie-chiu]

🏷 2021.31