feat: change query predicate to text #16160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eschutho
changed the title
Codecov Report
@@ Coverage Diff @@
## master #16160 +/- ##
==========================================
- Coverage 76.82% 76.55% -0.27%
==========================================
Files 996 996
Lines 52940 52940
Branches 6732 6732
==========================================
- Hits 40670 40529 -141
- Misses 12045 12186 +141
Partials 225 225
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
8 tasks
|
❗ Please consider rebasing your branch to avoid db migration conflicts. |
eschutho
force-pushed
the
elizabeth/change-query-predicate-to-text
branch
from
51eaf08
to
25e9041
Compare
betodealmeida
requested changes
Aug 10, 2021
.pylintrc
Outdated
| @@ -251,7 +251,7 @@ expected-line-ending-format= | |||
| # Logging modules to check that the string format arguments are in logging | |||
| # function parameter format | |||
| logging-modules=logging | |||
|
|
|||
| disable=logging-fstring-interpolation | |||
There was a problem hiding this comment.
Suggested change
| disable=logging-fstring-interpolation |
Using f-strings with logging is not considered safe because if the string interpolation fails nothing gets logged. if you use the old-school string interpolation then the message always get logged, even if the interpolation fails.
| for row in rows: | ||
| row.fetch_values_predicate = None | ||
|
|
||
| logging.info(f"{len(rows)} values deleted") |
There was a problem hiding this comment.
Suggested change
| logging.info(f"{len(rows)} values deleted") | |
| logging.info("%d values deleted", len(rows)) |
eschutho
force-pushed
the
elizabeth/change-query-predicate-to-text
branch
from
6677923
to
c4f44ca
Compare
eschutho
force-pushed
the
elizabeth/change-query-predicate-to-text
branch
from
c4f44ca
to
3ab46fb
Compare
betodealmeida
approved these changes
Aug 11, 2021
stevenuray
pushed a commit
to preset-io/superset
that referenced
this pull request
Aug 11, 2021
* change query predicate to text * make input multiline * remove value that is too long for the downgrade * keep logging lint rule (cherry picked from commit 628169a)
villebro
pushed a commit
that referenced
this pull request
Aug 16, 2021
* change query predicate to text * make input multiline * remove value that is too long for the downgrade * keep logging lint rule (cherry picked from commit 628169a)
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
* change query predicate to text * make input multiline * remove value that is too long for the downgrade * keep logging lint rule
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
* change query predicate to text * make input multiline * remove value that is too long for the downgrade * keep logging lint rule (cherry picked from commit 628169a)
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
* change query predicate to text * make input multiline * remove value that is too long for the downgrade * keep logging lint rule
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
* change query predicate to text * make input multiline * remove value that is too long for the downgrade * keep logging lint rule (cherry picked from commit 628169a)
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* change query predicate to text * make input multiline * remove value that is too long for the downgrade * keep logging lint rule (cherry picked from commit c345885)
mistercrunch
added
🍒 1.3.0
🍒 1.3.1
🍒 1.3.2
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
changes query predicate to text to accommodate longer strings
Closes #16100
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Results from migration script:
Current: 0.34 s
10+: 0.22 s
100+: 0.23 s
1000+: 0.37 s
ADDITIONAL INFORMATION