fix: revert data endpoint name #16162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16162 +/- ##
==========================================
- Coverage 76.82% 76.68% -0.14%
==========================================
Files 996 996
Lines 52940 52942 +2
Branches 6732 6734 +2
==========================================
- Hits 40670 40601 -69
- Misses 12045 12116 +71
Partials 225 225
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hughhhh
reviewed
Aug 10, 2021
| @@ -132,7 +132,7 @@ const ExploreChartPanel = props => { | |||
| const { slice } = props; | |||
| const updateQueryContext = useCallback( | |||
| async function fetchChartData() { | |||
| if (slice && slice.query_context === null) { | |||
| if (props.can_overwrite && slice && slice.query_context === null) { | |||
There was a problem hiding this comment.
deconstruct can_overwrite above then use just can_overwrite in if
const { can_overwrite, slice } = props;
hughhhh
approved these changes
Aug 10, 2021
stevenuray
pushed a commit
to preset-io/superset
that referenced
this pull request
Aug 11, 2021
(cherry picked from commit 7b3fce7)
villebro
pushed a commit
that referenced
this pull request
Aug 16, 2021
(cherry picked from commit 7b3fce7)
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
(cherry picked from commit 7b3fce7)
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
(cherry picked from commit 7b3fce7)
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
(cherry picked from commit 731874a)
mistercrunch
added
🍒 1.3.0
🍒 1.3.1
🍒 1.3.2
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Rename
post_databack todata, since it's giving permission errors.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION