Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update covid dashboard #16183

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

eschutho
Copy link
Member

@eschutho eschutho commented Aug 11, 2021

SUMMARY

This updates the covid dashboard with more recent data, and also renames some datasets.

The underlying data in this dataset has been updated. Do get those updates, you'll need to run superset load-examples -f. The dashboard changes in the PR will continue to work with the existing data as well.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

COVID_Vaccine_Dashboard
COVID_Vaccine_Dashboard

TESTING INSTRUCTIONS

check that the new dashboards and datasets are working properly

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #16183 (305321c) into master (3f86a54) will decrease coverage by 0.21%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16183      +/-   ##
==========================================
- Coverage   76.83%   76.62%   -0.22%     
==========================================
  Files         996      996              
  Lines       53025    53020       -5     
  Branches     6748     6748              
==========================================
- Hits        40742    40624     -118     
- Misses      12057    12170     +113     
  Partials      226      226              
Flag Coverage Δ
hive ?
mysql 81.61% <0.00%> (+0.01%) ⬆️
postgres 81.63% <0.00%> (+0.05%) ⬆️
presto ?
python 81.72% <0.00%> (-0.42%) ⬇️
sqlite 81.27% <0.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/examples/energy.py 26.19% <0.00%> (ø)
superset/examples/world_bank.py 30.55% <0.00%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 69.80% <0.00%> (-16.87%) ⬇️
superset/db_engine_specs/presto.py 83.47% <0.00%> (-6.91%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 88.03% <0.00%> (-1.66%) ⬇️
superset/db_engine_specs/base.py 87.98% <0.00%> (-0.39%) ⬇️
superset/models/core.py 89.61% <0.00%> (-0.26%) ⬇️
superset/utils/core.py 88.72% <0.00%> (-0.13%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f86a54...305321c. Read the comment docs.

@eschutho eschutho merged commit 3aefa69 into apache:master Aug 11, 2021
@eschutho eschutho deleted the elizabeth/update-covid-dashboard branch August 11, 2021 03:47
stevenuray pushed a commit to preset-io/superset that referenced this pull request Aug 11, 2021
(cherry picked from commit 3aefa69)
@AAfghahi AAfghahi mentioned this pull request Aug 12, 2021
9 tasks
@villebro villebro added the v1.3 label Aug 16, 2021
villebro pushed a commit that referenced this pull request Aug 16, 2021
(cherry picked from commit 3aefa69)
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
(cherry picked from commit 3aefa69)
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
(cherry picked from commit 50bb10a)
@mistercrunch mistercrunch added 🍒 1.3.0 🍒 1.3.1 🍒 1.3.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2021.31 preset-io size/XXL v1.3 🍒 1.3.0 🍒 1.3.1 🍒 1.3.2 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants